From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>,
Junio C Hamano <gitster@pobox.com>,
Ramsay Jones <ramsay@ramsayjones.plus.com>
Subject: Re: [PATCH v4 03/19] builtin/diff-tree: convert to struct object_id
Date: Tue, 21 Feb 2017 01:10:58 +0000 [thread overview]
Message-ID: <20170221011058.cpx7uio6ibkvrtbv@genre.crustytoothpaste.net> (raw)
In-Reply-To: <20170221010836.nuv6uvyzatql2yyu@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Mon, Feb 20, 2017 at 08:08:36PM -0500, Jeff King wrote:
> On Tue, Feb 21, 2017 at 12:25:19AM +0000, brian m. carlson wrote:
>
> > On Mon, Feb 20, 2017 at 03:09:02AM -0500, Jeff King wrote:
> > > It's a little disturbing that we do not seem to have even a basic test
> > > of:
> > >
> > > git rev-list --parents HEAD | git diff-tree --stdin
> > >
> > > which would exercise this code.
> >
> > I'm unsure, so I'll add a test. The only way to know if it works is to
> > test it.
>
> Not to spoil the ending, but I did test and it does not work. :)
Well, then I suppose I'll also end up sending out a new patch series. :)
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2017-02-21 1:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 0:10 [PATCH v4 00/19] object_id part 6 brian m. carlson
2017-02-20 0:10 ` [PATCH v4 01/19] hex: introduce parse_oid_hex brian m. carlson
2017-02-20 0:10 ` [PATCH v4 02/19] builtin/commit: convert to struct object_id brian m. carlson
2017-02-20 0:10 ` [PATCH v4 03/19] builtin/diff-tree: " brian m. carlson
2017-02-20 8:09 ` Jeff King
2017-02-21 0:25 ` brian m. carlson
2017-02-21 1:08 ` Jeff King
2017-02-21 1:10 ` brian m. carlson [this message]
2017-02-20 0:10 ` [PATCH v4 04/19] builtin/describe: " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 05/19] builtin/fast-export: " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 06/19] builtin/fmt-merge-message: " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 07/19] builtin/grep: " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 08/19] builtin/branch: " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 09/19] builtin/clone: " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 10/19] builtin/merge: " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 11/19] Convert remaining callers of resolve_refdup to object_id brian m. carlson
2017-02-20 0:10 ` [PATCH v4 12/19] builtin/replace: convert to struct object_id brian m. carlson
2017-02-20 0:10 ` [PATCH v4 13/19] reflog-walk: convert struct reflog_info " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 14/19] refs: convert each_reflog_ent_fn " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 15/19] refs: simplify parsing of reflog entries brian m. carlson
2017-02-20 0:10 ` [PATCH v4 16/19] sha1_file: introduce an nth_packed_object_oid function brian m. carlson
2017-02-20 0:10 ` [PATCH v4 17/19] Convert object iteration callbacks to struct object_id brian m. carlson
2017-02-20 0:10 ` [PATCH v4 18/19] builtin/merge-base: convert " brian m. carlson
2017-02-20 0:10 ` [PATCH v4 19/19] wt-status: " brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221011058.cpx7uio6ibkvrtbv@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).