git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Siddharth Kannan <kannan.siddharth12@gmail.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Feb 2017, #02; Mon, 6)
Date: Wed, 8 Feb 2017 22:46:58 -0500	[thread overview]
Message-ID: <20170209034657.qbkzbbzuvjpxl422@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqzihzymn3.fsf@gitster.mtv.corp.google.com>

On Mon, Feb 06, 2017 at 02:34:08PM -0800, Junio C Hamano wrote:

> * sk/parse-remote-cleanup (2017-02-06) 1 commit
>   (merged to 'next' on 2017-02-06 at 6ec89f72d5)
>  + parse-remote: remove reference to unused op_prep
> 
>  Code clean-up.
> 
>  Will merge to 'master'.

Hrm. Are the functions in git-parse-remote.sh part of the public API?
That is, do we expect third-party scripts to do:

  . "$(git rev-parse --exec)/git-parse-remote.sh
  error_on_missing_default_upstream "$a" "$b" "$c" "$d"

? If so, then they may be surprised by the change in function signature.

I generally think of git-sh-setup as the one that external scripts would
use. There _is_ a manpage for git-parse-remote, but it doesn't list any
functions. So maybe they're all fair game for changing?

I just didn't see any discussion of this in the original patch thread,
so I wanted to make sure we were making that decision consciously, and
not accidentally. :)

-Peff

  parent reply	other threads:[~2017-02-09  3:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 22:34 What's cooking in git.git (Feb 2017, #02; Mon, 6) Junio C Hamano
2017-02-07  0:24 ` SZEDER Gábor
2017-02-07  1:17   ` Jacob Keller
2017-02-07 20:01   ` Junio C Hamano
2017-02-09  0:25 ` Stefan Beller
2017-02-09  1:01   ` Junio C Hamano
2017-02-09  3:46 ` Jeff King [this message]
2017-02-09  5:09   ` Junio C Hamano
2017-02-10 21:17     ` Junio C Hamano
2017-02-09 12:29 ` Johannes Schindelin
2017-02-09 17:20   ` Junio C Hamano
2017-02-09 20:37     ` Johannes Schindelin
2017-02-09 22:02       ` Junio C Hamano
2017-02-09 22:32         ` Johannes Schindelin
2017-02-09 16:08 ` Michael Haggerty
2017-02-09 19:18   ` Junio C Hamano
2017-02-09 19:24   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170209034657.qbkzbbzuvjpxl422@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kannan.siddharth12@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).