From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Duy Nguyen <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] document behavior of empty color name
Date: Sat, 4 Feb 2017 01:49:45 +0100 [thread overview]
Message-ID: <20170204004944.cnhy3lthcuocgltm@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqy3xnf8jm.fsf@gitster.mtv.corp.google.com>
On Fri, Feb 03, 2017 at 10:12:13AM -0800, Junio C Hamano wrote:
> > Right, I think that's the correct behavior. The empty color name is a
> > real color ("none"), and you can put it in your list just like any other
> > color.
>
> Makes me wonder if we have a non-empty string that spells the same
> "do nothing", because ...
I don't think we do. "plain" or "none" or something would work. Or I
suppose "reset". That is not the same thing, but for practical purposes
it probably is.
> The above is just me "wondering"; I do not think what we have needs
> further tweaks--an empty after the final comma that means "do-nothing"
> is fine, I would think.
Yeah. I think doing anything more fancy opens more questions than it
answers.
-Peff
next prev parent reply other threads:[~2017-02-04 0:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 22:45 What's cooking in git.git (Jan 2017, #06; Tue, 31) Junio C Hamano
2017-02-01 0:21 ` [PATCH] color_parse_mem: allow empty color spec Jeff King
2017-02-01 1:19 ` Jacob Keller
2017-02-02 9:16 ` Duy Nguyen
2017-02-02 12:42 ` [PATCH] document behavior of empty color name Jeff King
2017-02-03 9:24 ` Duy Nguyen
2017-02-03 12:29 ` Jeff King
2017-02-03 18:12 ` Junio C Hamano
2017-02-04 0:49 ` Jeff King [this message]
2017-02-01 11:08 ` What's cooking in git.git (Jan 2017, #06; Tue, 31) Patrick Steinhardt
2017-02-01 18:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170204004944.cnhy3lthcuocgltm@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).