From: cornelius.weig@tngtech.com
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net,
Cornelius Weig <cornelius.weig@tngtech.com>
Subject: [PATCH] doc: add note about ignoring --no-create-reflog
Date: Wed, 1 Feb 2017 23:07:27 +0100 [thread overview]
Message-ID: <20170201220727.18070-1-cornelius.weig@tngtech.com> (raw)
From: Cornelius Weig <cornelius.weig@tngtech.com>
The commands git-branch and git-tag accept a `--create-reflog` argument.
On the other hand, the negated form `--no-create-reflog` is accepted as
a valid option but has no effect. This silent noop may puzzle users.
To communicate that this behavior is intentional, add a short note in
the manuals for git-branch and git-tag.
Signed-off-by: Cornelius Weig <cornelius.weig@tngtech.com>
---
Notes:
In a previous discussion (<xmqqbmunrwbf.fsf@gitster.mtv.corp.google.com>) it
was found that git-branch and git-tag accept a "--no-create-reflog" argument,
but it has no effect, does not produce a warning, and is undocumented.
Documentation/git-branch.txt | 1 +
Documentation/git-tag.txt | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/git-branch.txt b/Documentation/git-branch.txt
index 1fae4ee..fca3754 100644
--- a/Documentation/git-branch.txt
+++ b/Documentation/git-branch.txt
@@ -91,6 +91,7 @@ OPTIONS
based sha1 expressions such as "<branchname>@\{yesterday}".
Note that in non-bare repositories, reflogs are usually
enabled by default by the `core.logallrefupdates` config option.
+ The negated form `--no-create-reflog` is silently ignored.
-f::
--force::
diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt
index 5b2288c..b0b933e 100644
--- a/Documentation/git-tag.txt
+++ b/Documentation/git-tag.txt
@@ -152,6 +152,7 @@ This option is only applicable when listing tags without annotation lines.
--create-reflog::
Create a reflog for the tag. To globally enable reflogs for tags, see
`core.logAllRefUpdates` in linkgit:git-config[1].
+ The negated form `--no-create-reflog` is silently ignored.
<tagname>::
The name of the tag to create, delete, or describe.
--
2.10.2
next reply other threads:[~2017-02-01 22:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 22:07 cornelius.weig [this message]
2017-02-01 22:30 ` [PATCH] doc: add note about ignoring --no-create-reflog Junio C Hamano
2017-02-01 22:35 ` Jeff King
2017-02-01 23:11 ` Junio C Hamano
2017-02-01 23:19 ` Cornelius Weig
2017-02-01 23:19 ` Jeff King
2017-02-01 23:23 ` Cornelius Weig
2017-02-01 23:27 ` Junio C Hamano
2017-02-01 23:32 ` Jeff King
2017-02-01 23:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201220727.18070-1-cornelius.weig@tngtech.com \
--to=cornelius.weig@tngtech.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).