From: Jeff King <peff@peff.net>
To: santiago@nyu.edu
Cc: git@vger.kernel.org, gitster@pobox.com, sunshine@sunshineco.com,
walters@verbum.org, Lukas Puehringer <luk.puehringer@gmail.com>
Subject: Re: [PATCH v5 3/7] tag: add format specifier to gpg_verify_tag
Date: Tue, 17 Jan 2017 10:30:19 -0500 [thread overview]
Message-ID: <20170117153019.gujiruwghkwfklgv@sigill.intra.peff.net> (raw)
In-Reply-To: <20170117152455.k6zkeclsyawzpl2n@sigill.intra.peff.net>
On Tue, Jan 17, 2017 at 10:24:55AM -0500, Jeff King wrote:
> On Sun, Jan 15, 2017 at 01:47:01PM -0500, santiago@nyu.edu wrote:
>
> > From: Lukas Puehringer <luk.puehringer@gmail.com>
> >
> > Calling functions for gpg_verify_tag() may desire to print relevant
> > information about the header for further verification. Add an optional
> > format argument to print any desired information after GPG verification.
>
> Hrm. Maybe I am missing something, but what does:
>
> verify_and_format_tag(sha1, name, fmt, flags);
>
> get you over:
>
> gpg_verify_tag(sha1, name, flags);
> pretty_print_ref(name, sha1, fmt);
>
> ? The latter seems much more flexible, and I do not see how the
> verification step impacts the printing at all (or vice versa).
>
> I could understand it more if there were patches later in the series
> that somehow used the format and verification results together. But I
> didn't see that.
Having read through the rest of the series, it looks like you'd
sometimes have to do:
int ret;
ret = gpg_verify_tag(sha1, name, flags);
pretty_print_ref(name, sha1, fmt);
if (ret)
... do something ...
and this function lets you do it in a single line.
Still, I think I'd rather see it done as a wrapper than modifying
gpg_verify_tag().
-Peff
next prev parent reply other threads:[~2017-01-17 15:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 18:46 [PATCH v5 0/7] Add --format to tag verification santiago
2017-01-15 18:46 ` [PATCH v5 1/7] gpg-interface, tag: add GPG_VERIFY_QUIET flag santiago
2017-01-15 18:47 ` [PATCH v5 2/7] ref-filter: add function to print single ref_array_item santiago
2017-01-15 18:47 ` [PATCH v5 3/7] tag: add format specifier to gpg_verify_tag santiago
2017-01-17 15:24 ` Jeff King
2017-01-17 15:30 ` Jeff King [this message]
2017-01-17 16:57 ` Santiago Torres
2017-01-17 17:25 ` Jeff King
2017-01-17 17:30 ` Jeff King
2017-01-17 17:33 ` Santiago Torres
2017-01-17 17:34 ` Jeff King
2017-01-15 18:47 ` [PATCH v5 4/7] builtin/verify-tag: add --format to verify-tag santiago
2017-01-15 18:47 ` [PATCH v5 5/7] builtin/tag: add --format argument for tag -v santiago
2017-01-17 15:34 ` Jeff King
2017-01-17 17:00 ` Santiago Torres
2017-01-17 17:32 ` Jeff King
2017-01-17 17:34 ` Santiago Torres
2017-01-15 18:47 ` [PATCH v5 6/7] t/t7030-verify-tag: Add --format specifier tests santiago
2017-01-15 18:47 ` [PATCH v5 7/7] t/t7004-tag: " santiago
2017-01-17 15:35 ` Jeff King
2017-01-17 15:36 ` [PATCH v5 0/7] Add --format to tag verification Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117153019.gujiruwghkwfklgv@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luk.puehringer@gmail.com \
--cc=santiago@nyu.edu \
--cc=sunshine@sunshineco.com \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).