From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/3] fixing some random blame corner cases
Date: Thu, 5 Jan 2017 23:15:41 -0500 [thread overview]
Message-ID: <20170106041541.rjzzofal5hscv6yi@sigill.intra.peff.net> (raw)
Here are three fixes for some fairly obscure corner cases. I haven't
actually seen these in the wild. I came up with the final one while
discussing a hypothetical with somebody, then ran across the middle one
while trying to write a test for the third, which made me scratch my
head enough to yield the first one. Classic yak-shaving.
One other thing that surprised me while writing blame tests is that
"--root" is not the default for git-blame (though it has been for many
years in git-log). I'm not sure if it would be a good idea to change it,
or if blame is too plumbing-ish to allow that.
[1/3]: blame: fix alignment with --abbrev=40
[2/3]: blame: handle --no-abbrev
[3/3]: blame: output porcelain "previous" header for each file
builtin/blame.c | 27 ++++++----
t/t8002-blame.sh | 32 ++++++++++++
t/t8011-blame-split-file.sh | 117 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 166 insertions(+), 10 deletions(-)
create mode 100755 t/t8011-blame-split-file.sh
-Peff
next reply other threads:[~2017-01-06 4:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 4:15 Jeff King [this message]
2017-01-06 4:17 ` [PATCH 1/3] blame: fix alignment with --abbrev=40 Jeff King
2017-01-06 4:18 ` [PATCH 2/3] blame: handle --no-abbrev Jeff King
2017-01-06 4:20 ` [PATCH 3/3] blame: output porcelain "previous" header for each file Jeff King
2017-01-09 21:57 ` Junio C Hamano
2017-03-27 21:08 ` Ævar Arnfjörð Bjarmason
2017-03-27 22:04 ` Jeff King
2017-01-08 3:39 ` [PATCH 0/3] fixing some random blame corner cases Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106041541.rjzzofal5hscv6yi@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).