From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 40F4B205C9 for ; Wed, 4 Jan 2017 07:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752948AbdADHFS (ORCPT ); Wed, 4 Jan 2017 02:05:18 -0500 Received: from cloud.peff.net ([104.130.231.41]:34990 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822AbdADHFR (ORCPT ); Wed, 4 Jan 2017 02:05:17 -0500 Received: (qmail 1519 invoked by uid 109); 4 Jan 2017 07:05:16 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Wed, 04 Jan 2017 07:05:16 +0000 Received: (qmail 30171 invoked by uid 111); 4 Jan 2017 07:06:06 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Wed, 04 Jan 2017 02:06:06 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 04 Jan 2017 02:05:14 -0500 Date: Wed, 4 Jan 2017 02:05:14 -0500 From: Jeff King To: Michael J Gruber Cc: git@vger.kernel.org Subject: Re: [RFC PATCH 0/5] Localise error headers Message-ID: <20170104070514.pxdthvilw66ierfz@sigill.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jan 02, 2017 at 12:14:49PM +0100, Michael J Gruber wrote: > Currently, the headers "error: ", "warning: " etc. - generated by die(), > warning() etc. - are not localized, but we feed many localized error messages > into these functions so that we produce error messages with mixed localisation. > > This series introduces variants of die() etc. that use localised variants of > the headers, i.e. _("error: ") etc., and are to be fed localized messages. So, > instead of die(_("not workee")), which would produce a mixed localisation (such > as "error: geht ned"), one should use die_(_("not workee")) (resulting in > "Fehler: geht ned"). I can't say I'm excited about having matching "_" variants for each function. Are we sure that they are necessary? I.e., would it be acceptable to just translate them always? > 1/5 prepares the error machinery > 2/5 provides new variants error_() etc. > 3/5 has coccinelli rules error(_(E)) -> error_(_(E)) etc. > 4/5 applies the coccinelli patches > > 5/5 is not to be applied to the main tree, but helps you try out the feature: > it has changes to de.po and git.pot so that e.g. "git branch" has fully localised > error messages (see the recipe in the commit message). Your patches 4 and 5 don't seem to have made it to the list. Judging from the diffstat, I'd guess they broke the 100K limit. -Peff