From: Pranit Bauva <pranit.bauva@gmail.com>
To: git@vger.kernel.org
Cc: sbeller@google.com, luke@diamond.org, j6t@kdbg.org,
Pranit Bauva <pranit.bauva@gmail.com>
Subject: [PATCH v2 2/2] t9813: avoid using pipes
Date: Tue, 3 Jan 2017 00:15:36 +0530 [thread overview]
Message-ID: <20170102184536.10488-2-pranit.bauva@gmail.com> (raw)
In-Reply-To: <20170102184536.10488-1-pranit.bauva@gmail.com>
In-Reply-To: <20161231114412.23439-1-pranit.bauva@gmail.com>
The exit code of the upstream in a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we can
test the exit codes of both the commands.
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
---
t/t9813-git-p4-preserve-users.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t9813-git-p4-preserve-users.sh b/t/t9813-git-p4-preserve-users.sh
index 798bf2b67..9d7550ff3 100755
--- a/t/t9813-git-p4-preserve-users.sh
+++ b/t/t9813-git-p4-preserve-users.sh
@@ -118,12 +118,12 @@ test_expect_success 'not preserving user with mixed authorship' '
make_change_by_user usernamefile3 Derek derek@example.com &&
P4EDITOR=cat P4USER=alice P4PASSWD=secret &&
export P4EDITOR P4USER P4PASSWD &&
- git p4 commit |\
- grep "git author derek@example.com does not match" &&
+ git p4 commit >actual 2>&1 &&
+ grep "git author derek@example.com does not match" actual &&
make_change_by_user usernamefile3 Charlie charlie@example.com &&
- git p4 commit |\
- grep "git author charlie@example.com does not match" &&
+ git p4 commit >actual 2>&1 &&
+ grep "git author charlie@example.com does not match" actual &&
make_change_by_user usernamefile3 alice alice@example.com &&
git p4 commit >actual 2>&1 &&
--
2.11.0
next prev parent reply other threads:[~2017-01-02 18:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-31 11:44 [PATCH] don't use test_must_fail with grep Pranit Bauva
2017-01-01 14:23 ` Luke Diamand
2017-01-01 14:50 ` Johannes Sixt
2017-01-01 15:24 ` Luke Diamand
2017-01-02 13:40 ` Pranit Bauva
2017-01-07 21:18 ` Junio C Hamano
2017-01-08 16:53 ` Pranit Bauva
2017-01-02 18:45 ` [PATCH v2 1/2] " Pranit Bauva
2017-01-03 19:57 ` [PATCH v3 " Pranit Bauva
2017-01-08 16:55 ` [PATCH v4 " Pranit Bauva
2017-01-08 16:55 ` [PATCH v4 2/2] t9813: avoid using pipes Pranit Bauva
2017-01-09 9:11 ` Luke Diamand
2017-01-09 9:54 ` Junio C Hamano
2017-01-03 19:57 ` [PATCH v3 " Pranit Bauva
2017-01-04 9:11 ` Luke Diamand
2017-01-04 11:49 ` Pranit Bauva
2017-01-02 18:45 ` Pranit Bauva [this message]
2017-01-03 17:58 ` [PATCH v2 " Stefan Beller
2017-01-03 19:44 ` Pranit Bauva
2017-01-03 19:48 ` Stefan Beller
2017-01-03 17:52 ` [PATCH] don't use test_must_fail with grep Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102184536.10488-2-pranit.bauva@gmail.com \
--to=pranit.bauva@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=luke@diamond.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).