From: Jeff King <peff@peff.net>
To: "A. Wilcox" <awilfox@adelielinux.org>
Cc: git@vger.kernel.org
Subject: Re: Test failures when Git is built with libpcre and grep is built without it
Date: Mon, 2 Jan 2017 01:53:51 -0500 [thread overview]
Message-ID: <20170102065351.7ymrm77asjbghgdg@sigill.intra.peff.net> (raw)
In-Reply-To: <58688C9F.4000605@adelielinux.org>
On Sat, Dec 31, 2016 at 10:59:11PM -0600, A. Wilcox wrote:
> I'm attempting to package Git for our new Linux distribution and I
> have run in to a failure on our PowerPC builder while running the test
> suite.
>
> The PowerPC builder runs a tiny version of grep(1) that was not built
> with PCRE. As such, grep -P returns 2 and prints:
>
> grep: support for the -P option is not compiled into this
> - --disable-perl-regexp binary
>
> However, our Git build *does* link against libpcre. This causes a
> tests numbered 142 and 143 to fail in t7810-grep.sh.
If we are using "grep -P" in our test suite, it should definitely be
marked with a prerequisite that is independent of the LIBPCRE one.
But I can't find any such place in our test suite. Grepping for
"grep.*-P" doesn't turn up any hits, and dropping this into my PATH as
"grep":
#!/bin/sh
case "$*" in
*-P*|*perl-regex*)
echo >&2 "Pretending not to understand -P"
exit 1
esac
exec /bin/grep "$@"
doesn't break anything. We do call "git grep -P", of course, but that
should be using the internal libpcre (once upon a time we would invoke
an external grep, but that feature has been gone for years).
Can you show us the output of "./t7810-grep.sh -v -i"?
-Peff
next prev parent reply other threads:[~2017-01-02 6:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 4:59 Test failures when Git is built with libpcre and grep is built without it A. Wilcox
2017-01-01 10:19 ` Torsten Bögershausen
2017-01-02 6:53 ` Jeff King [this message]
2017-01-09 10:51 ` A. Wilcox
2017-01-09 11:27 ` Jeff King
2017-01-09 13:05 ` Andreas Schwab
2017-01-09 21:33 ` Jeff King
2017-01-10 10:36 ` A. Wilcox
2017-01-10 11:40 ` [musl] " Szabolcs Nagy
2017-01-11 10:04 ` Jeff King
2017-01-11 11:10 ` [PATCH] t7810: avoid assumption about invalid regex syntax Jeff King
2017-01-11 20:49 ` [musl] Re: Test failures when Git is built with libpcre and grep is built without it Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102065351.7ymrm77asjbghgdg@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=awilfox@adelielinux.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).