From: Duy Nguyen <pclouds@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2 02/21] config: add git_config_get_split_index()
Date: Mon, 19 Dec 2016 18:14:42 +0700 [thread overview]
Message-ID: <20161219111442.GA24125@ash> (raw)
In-Reply-To: <20161217145547.11748-3-chriscool@tuxfamily.org>
On Sat, Dec 17, 2016 at 03:55:28PM +0100, Christian Couder wrote:
> diff --git a/config.c b/config.c
> index 2eaf8ad77a..c1343bbb3e 100644
> --- a/config.c
> +++ b/config.c
> @@ -1709,6 +1709,16 @@ int git_config_get_untracked_cache(void)
> return -1; /* default value */
> }
>
> +int git_config_get_split_index(void)
> +{
> + int val = -1;
Is it redundant to set default value here because it's not used
anywhere? The "return val;" will always have the new value from
git_config_. And you don't use "val" in error case.
> +
> + if (!git_config_get_maybe_bool("core.splitindex", &val))
> + return val;
> +
> + return -1; /* default value */
> +}
> +
> NORETURN
> void git_die_config_linenr(const char *key, const char *filename, int linenr)
> {
> --
> 2.11.0.49.g2414764.dirty
>
next prev parent reply other threads:[~2016-12-19 11:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 14:55 [PATCH v2 00/21] Add configuration options for split-index Christian Couder
2016-12-17 14:55 ` [PATCH v2 01/21] config: mark an error message up for translation Christian Couder
2016-12-17 14:55 ` [PATCH v2 02/21] config: add git_config_get_split_index() Christian Couder
2016-12-19 11:14 ` Duy Nguyen [this message]
2016-12-26 8:15 ` Christian Couder
2016-12-17 14:55 ` [PATCH v2 03/21] split-index: add {add,remove}_split_index() functions Christian Couder
2016-12-17 14:55 ` [PATCH v2 04/21] read-cache: add and then use tweak_split_index() Christian Couder
2016-12-19 11:18 ` Duy Nguyen
2016-12-26 8:20 ` Christian Couder
2016-12-17 14:55 ` [PATCH v2 05/21] update-index: warn in case of split-index incoherency Christian Couder
2016-12-17 14:55 ` [PATCH v2 06/21] t1700: add tests for core.splitIndex Christian Couder
2016-12-17 14:55 ` [PATCH v2 07/21] Documentation/config: add information " Christian Couder
2016-12-17 14:55 ` [PATCH v2 08/21] Documentation/git-update-index: talk about core.splitIndex config var Christian Couder
2016-12-17 14:55 ` [PATCH v2 09/21] config: add git_config_get_max_percent_split_change() Christian Couder
2016-12-17 14:55 ` [PATCH v2 10/21] read-cache: regenerate shared index if necessary Christian Couder
2016-12-19 11:48 ` Duy Nguyen
2016-12-26 8:33 ` Christian Couder
2016-12-17 14:55 ` [PATCH v2 11/21] t1700: add tests for splitIndex.maxPercentChange Christian Couder
2016-12-17 14:55 ` [PATCH v2 12/21] Documentation/config: add splitIndex.maxPercentChange Christian Couder
2016-12-17 14:55 ` [PATCH v2 13/21] sha1_file: make check_and_freshen_file() non static Christian Couder
2016-12-17 14:55 ` [PATCH v2 14/21] read-cache: touch shared index files when used Christian Couder
2016-12-17 14:55 ` [PATCH v2 15/21] config: add git_config_get_expiry() from gc.c Christian Couder
2016-12-17 14:55 ` [PATCH v2 16/21] read-cache: unlink old sharedindex files Christian Couder
2016-12-19 11:58 ` Duy Nguyen
2016-12-26 9:54 ` Christian Couder
2016-12-17 14:55 ` [PATCH v2 17/21] t1700: test shared index file expiration Christian Couder
2016-12-17 14:55 ` [PATCH v2 18/21] read-cache: refactor read_index_from() Christian Couder
2016-12-17 14:55 ` [PATCH v2 19/21] read-cache: use freshen_shared_index() in read_index_from() Christian Couder
2016-12-17 14:55 ` [PATCH v2 20/21] Documentation/config: add splitIndex.sharedIndexExpire Christian Couder
2016-12-17 14:55 ` [PATCH v2 21/21] Documentation/git-update-index: explain splitIndex.* Christian Couder
2016-12-17 15:35 ` [PATCH v2 00/21] Add configuration options for split-index Christian Couder
2016-12-19 12:02 ` Duy Nguyen
2016-12-19 21:03 ` Junio C Hamano
2016-12-26 10:32 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219111442.GA24125@ash \
--to=pclouds@gmail.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).