From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 865ED1FF40 for ; Thu, 15 Dec 2016 00:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934101AbcLOAV0 (ORCPT ); Wed, 14 Dec 2016 19:21:26 -0500 Received: from cloud.peff.net ([104.130.231.41]:56796 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933070AbcLOAVZ (ORCPT ); Wed, 14 Dec 2016 19:21:25 -0500 Received: (qmail 2395 invoked by uid 109); 15 Dec 2016 00:21:25 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Thu, 15 Dec 2016 00:21:25 +0000 Received: (qmail 30690 invoked by uid 111); 15 Dec 2016 00:22:04 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Wed, 14 Dec 2016 19:22:04 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 14 Dec 2016 19:21:20 -0500 Date: Wed, 14 Dec 2016 19:21:20 -0500 From: Jeff King To: Brandon Williams Cc: git@vger.kernel.org, gitster@pobox.com, sbeller@google.com, bburky@bburky.com, jrnieder@gmail.com Subject: Re: [PATCH v10 2/6] http: always warn if libcurl version is too old Message-ID: <20161215002120.xlnlquuqqw25wngc@sigill.intra.peff.net> References: <1481679637-133137-1-git-send-email-bmwill@google.com> <1481755195-174539-1-git-send-email-bmwill@google.com> <1481755195-174539-3-git-send-email-bmwill@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1481755195-174539-3-git-send-email-bmwill@google.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Dec 14, 2016 at 02:39:51PM -0800, Brandon Williams wrote: > Always warn if libcurl version is too old because: > > 1. Even without a protocol whitelist, newer versions of curl have all > non-http protocols disabled by default. Technically, non-http and non-ftp. Maybe just "non-standard" would be more accurate. Not worth a re-roll, but if Junio hasn't applied yet, maybe worth fixing up while applying. -Peff