From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.6 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id F1C93203EA for ; Sat, 10 Dec 2016 08:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704AbcLJI1B (ORCPT ); Sat, 10 Dec 2016 03:27:01 -0500 Received: from cloud.peff.net ([104.130.231.41]:54554 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbcLJI1A (ORCPT ); Sat, 10 Dec 2016 03:27:00 -0500 Received: (qmail 32155 invoked by uid 109); 10 Dec 2016 08:27:00 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Sat, 10 Dec 2016 08:27:00 +0000 Received: (qmail 24996 invoked by uid 111); 10 Dec 2016 08:27:39 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Sat, 10 Dec 2016 03:27:39 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Sat, 10 Dec 2016 03:26:57 -0500 Date: Sat, 10 Dec 2016 03:26:57 -0500 From: Jeff King To: Johannes Sixt Cc: Klaus Ethgen , git@vger.kernel.org Subject: Re: [BUG] Colon in remote urls Message-ID: <20161210082657.zjp52a2zdtqifmg3@sigill.intra.peff.net> References: <20161209140215.qlam6bexm5irpro2@ikki.ethgen.ch> <20161209152219.ehfk475vdg4levop@sigill.intra.peff.net> <88bed7c9-4d5d-45d5-5d13-6a8ae834e602@kdbg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <88bed7c9-4d5d-45d5-5d13-6a8ae834e602@kdbg.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Dec 09, 2016 at 10:32:48PM +0100, Johannes Sixt wrote: > > + if (*p == '\\') > > + literal = 1; > > There are too many systems out there that use a backslash in path names. I > don't think it is wise to use it also as the quoting character. Yeah, I picked it arbitrarily as the common quoting character, but I agree it probably makes backwards compatibility (and general usability when you have to double-backslash each instance) pretty gross on Windows. Most of the printable characters are going to suffer from backwards compatibility issues. Syntactically, we could use any ASCII control code below 0x20. Certainly our C code would be fine with that, but it seems pretty nasty. There's probably some crazy non-printing UTF-8 sequence we could use, too, but I'm not sure I want to go there. -Peff