From: Jeff King <peff@peff.net>
To: David Turner <David.Turner@twosigma.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"spearce@spearce.org" <spearce@spearce.org>
Subject: Re: [PATCH] remote-curl: don't hang when a server dies before any output
Date: Fri, 18 Nov 2016 09:08:55 -0800 [thread overview]
Message-ID: <20161118170855.22p3vhcocdxgmpy4@sigill.intra.peff.net> (raw)
In-Reply-To: <764305554fa74779ad5fb956aa2b658a@EXMBNJE7.ad.twosigma.com>
On Fri, Nov 18, 2016 at 05:04:59PM +0000, David Turner wrote:
> > So I don't feel like we have a good patch for the general case yet,
> > and I'm probably not going to get around to implementing it anytime
> > soon.
>
> I'm confused -- it sounds like your patch actually does work (that is,
> that Junio's failure was not caused by your patch but by the absence
> of our patches). And your patch handles more cases than mine. So we
> should probably use it instead of mine.
No, mine passes the vanilla test suite, but fails with GIT_TEST_LONG.
If the want/have negotiation takes multiple rounds, the intermediate
rounds don't end on a flush packet, and my patch causes remote-curl to
complain that the response was truncated.
I think you could fix it by teaching remote-curl that the final packet
must be a flush _or_ contain an ACK/NAK, but I didn't try it. That's
getting a bit invasive and brittle.
-Peff
next prev parent reply other threads:[~2016-11-18 17:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 22:18 [PATCH] remote-curl: don't hang when a server dies before any output David Turner
2016-11-14 18:24 ` Jeff King
2016-11-14 19:40 ` Jeff King
2016-11-14 21:19 ` Junio C Hamano
2016-11-14 21:33 ` Jeff King
2016-11-14 23:25 ` David Turner
2016-11-14 23:48 ` Jeff King
2016-11-15 15:45 ` David Turner
2016-11-15 0:44 ` Jeff King
2016-11-15 1:02 ` Junio C Hamano
2016-11-15 3:58 ` Jeff King
2016-11-15 17:42 ` Junio C Hamano
2016-11-18 17:01 ` Jeff King
2016-11-18 17:04 ` David Turner
2016-11-18 17:08 ` Jeff King [this message]
2016-11-18 17:48 ` David Turner
2016-11-18 18:28 ` Junio C Hamano
2016-11-15 2:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118170855.22p3vhcocdxgmpy4@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=David.Turner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).