From: Jeff King <peff@peff.net>
To: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Cc: Lars Schneider <larsxschneider@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
git <git@vger.kernel.org>,
me@ttaylorr.com
Subject: Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter
Date: Fri, 11 Nov 2016 15:27:10 -0500 [thread overview]
Message-ID: <20161111202710.7zpalypsnorqeclq@sigill.intra.peff.net> (raw)
In-Reply-To: <1478894572.12153.1.camel@kaarsemaker.net>
On Fri, Nov 11, 2016 at 09:02:52PM +0100, Dennis Kaarsemaker wrote:
> > > Are you sure about that? If I do:
> > >
> > > echo url=https://example.com/repo.git |
> > > git credential fill
> > >
> > > I get prompted for a username and password.
> >
> >
> > Hm.. either I don't understand you or I expressed myself unclear.
> >
> > Let's say a user runs:
> >
> > $ git clone https://myrepo.git
> >
> > If no credential helper is setup, then Git asks the user for credentials.
> > Afterwards Git starts downloading stuff. At some point Git will run my
> > smudge filter on some files and in my case the smudge filter needs the
> > Git credentials. AFAIK, the smudge filter has no way to get the credentials
> > from Git at this point - not even by invoking "git credential".
> > Is this correct?
>
> I think that's correct, but the same argument goes both ways: unless I
> use a credential helper, or explicitely give a filter application my
> credentials, I don't want a helper to be able to get to those
> credentials. I'd consider that a security bug.
Yeah, agreed. They are logically two separate operations, so I think it
is a feature that they do not implicitly share credentials.
I think the only place where we implicitly share credentials is when
serving an HTTP fetch or push requires multiple HTTP requests. And there
it seems pretty sane to do so.
-Peff
next prev parent reply other threads:[~2016-11-11 20:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 11:52 [RFC] Add way to make Git credentials accessible from clean/smudge filter Lars Schneider
2016-11-10 12:10 ` Matthieu Moy
2016-11-10 16:08 ` Jeff King
2016-11-11 9:28 ` Lars Schneider
2016-11-11 9:31 ` Jeff King
2016-11-11 9:40 ` Lars Schneider
2016-11-11 20:02 ` Dennis Kaarsemaker
2016-11-11 20:27 ` Jeff King [this message]
2016-11-12 13:57 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111202710.7zpalypsnorqeclq@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).