From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Drastic jump in the time required for the test suite
Date: Thu, 20 Oct 2016 17:38:03 -0400 [thread overview]
Message-ID: <20161020213803.7d7bymby7pouzij3@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kZpj5xXHmnA+JfLKdGmgzp7Mut1OsKMOeowpw8m1+aKGA@mail.gmail.com>
On Thu, Oct 20, 2016 at 12:54:32PM -0700, Stefan Beller wrote:
> Maybe we should stop introducing un-optimized tests.
> [...]
> * heavy use of the "git -C <dir>" pattern. When applying that
> thouroughly we'd save spanning the subshells.
Yeah, I imagine with some style changes we could drop quite a few
subshells. The problem is that the conversion work is manual and
tedious. I'd look first for spots where we can eliminate thousands of
calls with a single change.
> That said I really like the idea of having a helper that would eliminate the cat
> for you, e.g. :
>
> git_test_helper_equal_stdin_or_diff_and_die -C super_repo status
> --porcelain=v2 --branch --untracked-files=all <<-EOF
> 1 A. N... 000000 100644 100644 $_z40 $HMOD .gitmodules
> 1 AM S.M. 000000 160000 160000 $_z40 $HSUP sub1
> EOF
I think that helper still ends up using "cat" and "diff" under the hood,
unless you write those bits in pure shell. But at that point, I suspect
we could "cat" and "test_cmp" in pure shell, something like:
cat () {
# optimize common here-doc usage
if test $# -eq 0
then
while read -r line
do
printf '%s' "$line"
done
fi
command cat "$@"
}
test_cmp () {
# optimize for common "they are the same" case
# without any subshells or subprograms
while true; do
if ! read -r line1 <&3
then
if ! read -r line2 <&4
# EOF on both; good
return 0
else
# EOF only on file1; fail
break
fi
fi
if ! read -r line2 <&4
then
# EOF only on file2; fail
break
fi
test "$line1" = "$line2" || break
done 3<"$1" 4<"$2"
# if we get here, the optimized version found some
# difference. We can just "return 1", but let's run
# the real $GIT_TEST_CMP to provide pretty output.
# This should generally only happen on test failures,
# so performance isn't a big deal.
"$GIT_TEST_CMP" "$@"
}
Those are both completely untested. But maybe they are worth playing
around with for somebody on Windows to see if they make a dent in the
test runtime.
-Peff
next prev parent reply other threads:[~2016-10-20 21:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 9:18 Drastic jump in the time required for the test suite Johannes Schindelin
2016-10-19 17:32 ` Junio C Hamano
2016-10-19 20:56 ` Jeff King
2016-10-20 10:50 ` Johannes Schindelin
2016-10-20 11:39 ` Jeff King
2016-10-20 19:54 ` Stefan Beller
2016-10-20 21:38 ` Jeff King [this message]
2016-10-20 21:53 ` Stefan Beller
2016-10-20 21:57 ` Jeff King
2016-10-20 21:56 ` Jeff King
2016-10-21 5:27 ` Johannes Sixt
2016-10-21 8:24 ` Jeff King
2016-10-20 10:17 ` Johannes Schindelin
2016-10-20 12:31 ` Jeff King
2016-10-20 16:30 ` Stefan Beller
2016-10-20 21:00 ` Jeff King
2016-10-20 23:20 ` Jeff King
2016-10-20 20:38 ` Johannes Sixt
2016-10-20 21:03 ` Jeff King
2016-10-20 20:40 ` Dennis Kaarsemaker
2016-10-21 11:03 ` Duy Nguyen
2016-10-20 16:16 ` Junio C Hamano
2016-10-20 17:13 ` Matthieu Moy
2016-10-20 11:02 ` Duy Nguyen
2016-10-20 16:40 ` René Scharfe
2016-10-21 10:59 ` Duy Nguyen
2016-10-21 20:28 ` René Scharfe
2016-10-21 13:10 ` Matthieu Moy
2016-10-21 19:57 ` René Scharfe
2016-10-27 20:41 ` Eric Wong
2016-10-28 6:38 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020213803.7d7bymby7pouzij3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).