From: Jeff King <peff@peff.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Mathieu Lienard--Mayor <Mathieu.Lienard--Mayor@ensimag.imag.fr>,
Jorge Juan Garcia Garcia
<Jorge-Juan.Garcia-Garcia@ensimag.imag.fr>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
git@vger.kernel.org
Subject: Re: Formatting problem send_mail in version 2.10.0
Date: Mon, 10 Oct 2016 17:57:11 -0400 [thread overview]
Message-ID: <20161010215711.oqnoiz7qfmxm27cr@sigill.intra.peff.net> (raw)
In-Reply-To: <20161010214856.fobd3jgsv2cnscs3@sigill.intra.peff.net>
[+cc authors of b1c8a11, which regressed this case; I'll quote liberally
to give context]
On Mon, Oct 10, 2016 at 05:48:56PM -0400, Jeff King wrote:
> I can't reproduce the problem with this simple setup:
>
> git init
> echo content >file && git add file
> git commit -F- <<-\EOF
> the subject
>
> the body
>
> Cc: Stable <stable@vger.kernel.org> [4.8+]
> EOF
>
> If I then run:
>
> git send-email -1 --to=peff@peff.net --dry-run
>
> I get:
>
> /tmp/MH8SfHOjCv/0001-the-subject.patch
> (mbox) Adding cc: Jeff King <peff@peff.net> from line 'From: Jeff King <peff@peff.net>'
> (body) Adding cc: Stable <stable@vger.kernel.org> [4.8+] from line 'Cc: Stable <stable@vger.kernel.org> [4.8+]'
> Dry-OK. Log says:
> Sendmail: /usr/sbin/sendmail -i peff@peff.net stable@vger.kernel.org
> From: Jeff King <peff@peff.net>
> To: peff@peff.net
> Cc: "Stable [4.8+]" <stable@vger.kernel.org>
> Subject: [PATCH] the subject
> Date: Mon, 10 Oct 2016 17:44:25 -0400
> Message-Id: <20161010214425.9761-1-peff@peff.net>
> X-Mailer: git-send-email 2.10.1.527.g93d4615
>
> Result: OK
>
> So it looks like it parsed the address, and shifted the "4.8+" bit into
> the name, which seems reasonable. Does my example behave differently on
> your system? If not, can you see what's different between your
> real-world case and the example?
>
> It might also be related to which perl modules are available. We'll use
> Mail::Address if you have it, but some fallback routines if you don't.
> They may behave differently.
>
> Alternatively, if this used to work, you might try bisecting it.
Ah, it is Mail::Address. It gets this case right, but if I uninstall it,
then the cc becomes:
Cc: Stable <stable@vger.kernel.org[4.8+]>
that you saw, which is broken. Older versions of git, even without
Mail::Address, got this right. The breakage bisects to b1c8a11
(send-email: allow multiple emails using --cc, --to and --bcc,
2015-06-30) from v2.6.0, but I didn't dig deeper into the cause.
-Peff
next prev parent reply other threads:[~2016-10-10 21:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 21:00 Formatting problem send_mail in version 2.10.0 Larry Finger
2016-10-10 21:48 ` Jeff King
2016-10-10 21:57 ` Jeff King [this message]
2016-10-10 23:35 ` Larry Finger
2016-10-10 23:43 ` Jeff King
2016-10-11 7:39 ` Matthieu Moy
2016-10-11 15:42 ` Larry Finger
2016-10-11 16:18 ` Matthieu Moy
2016-10-12 4:28 ` Larry Finger
2016-10-12 7:36 ` Matthieu Moy
2016-10-12 15:27 ` Larry Finger
2016-10-12 15:40 ` Matthieu Moy
2016-10-12 15:40 ` Larry Finger
2016-10-12 15:45 ` Matthieu Moy
2016-10-12 15:59 ` Larry Finger
2016-10-12 20:53 ` Junio C Hamano
2016-10-12 23:13 ` Jeff King
2016-10-13 5:37 ` Matthieu Moy
2016-10-13 5:47 ` [PATCH] parse_mailboxes: accept extra text after <...> address Matthieu Moy
2016-10-13 15:33 ` Formatting problem send_mail in version 2.10.0 Kevin Daudt
2016-10-13 16:05 ` Matthieu Moy
2016-10-13 5:32 ` Matthieu Moy
2016-10-14 17:04 ` Junio C Hamano
2016-10-11 16:02 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010215711.oqnoiz7qfmxm27cr@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Jorge-Juan.Garcia-Garcia@ensimag.imag.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=Mathieu.Lienard--Mayor@ensimag.imag.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).