From: Jeff King <peff@peff.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: git@vger.kernel.org
Subject: Re: Formatting problem send_mail in version 2.10.0
Date: Mon, 10 Oct 2016 17:48:56 -0400 [thread overview]
Message-ID: <20161010214856.fobd3jgsv2cnscs3@sigill.intra.peff.net> (raw)
In-Reply-To: <41164484-309b-bfff-ddbb-55153495d41a@lwfinger.net>
On Mon, Oct 10, 2016 at 04:00:56PM -0500, Larry Finger wrote:
> I have recently switched to openSUSE Leap 42.2 and found that some of the
> features of send_mail no longer work. The problem occurs when trying to add
> information to a Cc to Stable.
>
> The initial pass through the patch produces the output
> (body) Adding cc: Stable <stable@vger.kernel.org> [4.8+] from line 'Cc:
> Stable <stable@vger.kernel.org> [4.8+]'
>
> That is correct, but the actual Cc list contains
> Stable <stable@vger.kernel.org[4.8+]>,
>
> The mangled address is not legal and the mail attempt fails.
I can't reproduce the problem with this simple setup:
git init
echo content >file && git add file
git commit -F- <<-\EOF
the subject
the body
Cc: Stable <stable@vger.kernel.org> [4.8+]
EOF
If I then run:
git send-email -1 --to=peff@peff.net --dry-run
I get:
/tmp/MH8SfHOjCv/0001-the-subject.patch
(mbox) Adding cc: Jeff King <peff@peff.net> from line 'From: Jeff King <peff@peff.net>'
(body) Adding cc: Stable <stable@vger.kernel.org> [4.8+] from line 'Cc: Stable <stable@vger.kernel.org> [4.8+]'
Dry-OK. Log says:
Sendmail: /usr/sbin/sendmail -i peff@peff.net stable@vger.kernel.org
From: Jeff King <peff@peff.net>
To: peff@peff.net
Cc: "Stable [4.8+]" <stable@vger.kernel.org>
Subject: [PATCH] the subject
Date: Mon, 10 Oct 2016 17:44:25 -0400
Message-Id: <20161010214425.9761-1-peff@peff.net>
X-Mailer: git-send-email 2.10.1.527.g93d4615
Result: OK
So it looks like it parsed the address, and shifted the "4.8+" bit into
the name, which seems reasonable. Does my example behave differently on
your system? If not, can you see what's different between your
real-world case and the example?
It might also be related to which perl modules are available. We'll use
Mail::Address if you have it, but some fallback routines if you don't.
They may behave differently.
Alternatively, if this used to work, you might try bisecting it.
-Peff
next prev parent reply other threads:[~2016-10-10 21:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 21:00 Formatting problem send_mail in version 2.10.0 Larry Finger
2016-10-10 21:48 ` Jeff King [this message]
2016-10-10 21:57 ` Jeff King
2016-10-10 23:35 ` Larry Finger
2016-10-10 23:43 ` Jeff King
2016-10-11 7:39 ` Matthieu Moy
2016-10-11 15:42 ` Larry Finger
2016-10-11 16:18 ` Matthieu Moy
2016-10-12 4:28 ` Larry Finger
2016-10-12 7:36 ` Matthieu Moy
2016-10-12 15:27 ` Larry Finger
2016-10-12 15:40 ` Matthieu Moy
2016-10-12 15:40 ` Larry Finger
2016-10-12 15:45 ` Matthieu Moy
2016-10-12 15:59 ` Larry Finger
2016-10-12 20:53 ` Junio C Hamano
2016-10-12 23:13 ` Jeff King
2016-10-13 5:37 ` Matthieu Moy
2016-10-13 5:47 ` [PATCH] parse_mailboxes: accept extra text after <...> address Matthieu Moy
2016-10-13 15:33 ` Formatting problem send_mail in version 2.10.0 Kevin Daudt
2016-10-13 16:05 ` Matthieu Moy
2016-10-13 5:32 ` Matthieu Moy
2016-10-14 17:04 ` Junio C Hamano
2016-10-11 16:02 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010214856.fobd3jgsv2cnscs3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Larry.Finger@lwfinger.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).