From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Duy Nguyen <pclouds@gmail.com>, Tom Hale <tom@hale.ee>,
git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] pretty: respect color settings for %C placeholders
Date: Mon, 10 Oct 2016 16:04:57 -0400 [thread overview]
Message-ID: <20161010200457.6dzcrkhoi5id3z4x@sigill.intra.peff.net> (raw)
In-Reply-To: <19e59db7-f3dd-35ec-8cf1-b070b1c05abe@web.de>
On Mon, Oct 10, 2016 at 09:59:17PM +0200, René Scharfe wrote:
> > > Shouldn't we have an "else" here?
> >
> > I'm not sure what you mean; can you write it out?
>
> > - if (skip_prefix(begin, "auto,", &begin)) {
> > +
> > + if (!skip_prefix(begin, "always,", &begin)) {
> > if (!want_color(c->pretty_ctx->color))
> > return end - placeholder + 1;
> > }
>
> else { /* here */
>
> > + /* this is a historical noop */
> > + skip_prefix(begin, "auto,", &begin);
>
> }
>
> Otherwise "always,auto," would be allowed and mean the same as "always,",
> which just seems wrong. Not a biggie.
I don't think that will parse "%C(auto,foo)", as we hit the
!skip_prefix() of the conditional, and do not look for "auto," at all.
I think you'd have to move the check for "auto," inside the if block.
I'm leaning towards just writing it out the long way, though, as I did
in my reply to Junio.
> > > Perhaps it's a funtion like add_color(sb, ctx, color) or similar would be
> > > nice?
> >
> > I actually wrote it that way first (I called it "maybe_add_color()"),
> > but it felt a little funny to have a separate function that people might
> > be tempted to reuse (the right solution is generally to check
> > want_color() early as above, but we can't do that here because we have
> > to find the end of each placeholder).
>
> OK. A variable then? Lazy pseudo-code:
>
> if (RED)
> color = red;
> else if (GREEN)
> ...
>
> if (want_color())
> strbuf_addstr(sb, color);
Yeah, that is a bit more clear (the final conditional just needs to
check that we actually found a color).
-Peff
next prev parent reply other threads:[~2016-10-10 20:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 5:43 %C(auto) not working as expected Tom Hale
2016-10-09 6:47 ` René Scharfe
2016-10-09 10:04 ` Tom Hale
2016-10-09 13:24 ` René Scharfe
2016-10-09 23:46 ` Jeff King
2016-10-10 9:26 ` Duy Nguyen
2016-10-10 14:28 ` Jeff King
2016-10-10 15:15 ` [PATCH] pretty: respect color settings for %C placeholders Jeff King
2016-10-10 17:09 ` René Scharfe
2016-10-10 17:42 ` Jeff King
2016-10-10 19:59 ` René Scharfe
2016-10-10 20:04 ` Jeff King [this message]
2016-10-10 18:52 ` Junio C Hamano
2016-10-10 18:59 ` Jeff King
2016-10-10 20:54 ` Jeff King
2016-10-11 10:59 ` Duy Nguyen
2016-10-25 12:52 ` %C(auto) not working as expected Duy Nguyen
2016-10-25 12:58 ` Jeff King
2016-10-25 13:02 ` Duy Nguyen
2016-10-10 20:52 ` René Scharfe
2016-10-10 20:55 ` Jeff King
2016-10-11 3:41 ` [PATCH v2] pretty: fix document link for color specification René Scharfe
2016-10-11 4:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010200457.6dzcrkhoi5id3z4x@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
--cc=tom@hale.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).