From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] tmp-objdir: mark some file local symbols static
Date: Sun, 2 Oct 2016 08:13:12 -0400 [thread overview]
Message-ID: <20161002121311.4febd7jtc4yv5fev@sigill.intra.peff.net> (raw)
In-Reply-To: <f5560f8b-75be-faa0-ce1c-5e2716ee82a5@ramsayjones.plus.com>
On Sun, Oct 02, 2016 at 12:07:27AM +0100, Ramsay Jones wrote:
> If you need to re-roll your 'jk/quarantine-received-objects' branch,
> could you please squash this into the relevant patches.
Oops, thanks. Don't know how I missed both of these.
> [I also note that tmp_objdir_destroy(), declared to be part of the
> public interface, is not currently called from outside tmp_objdir.c.
> Despite being unlikely, it is at least plausible that this function
> may be useful in future. ;-) ]
Yeah, builtin/receive-pack is happy to just rely on process death to
destroy it, but I think it's good to keep open an option for somebody to
do:
if (error) {
tmp_objdir_destroy(t);
return -1;
}
or similar.
-Peff
prev parent reply other threads:[~2016-10-02 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 23:07 [PATCH] tmp-objdir: mark some file local symbols static Ramsay Jones
2016-10-02 12:13 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161002121311.4febd7jtc4yv5fev@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).