From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kevin Daudt <me@ikke.info>,
git@vger.kernel.org, Swift Geek <swiftgeek@gmail.com>
Subject: Re: [PATCH v2 2/2] mailinfo: unescape quoted-pair in header fields
Date: Fri, 23 Sep 2016 00:15:41 -0400 [thread overview]
Message-ID: <20160923041540.5fvl6ytp2tvcflsk@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq60pn37gs.fsf@gitster.mtv.corp.google.com>
On Thu, Sep 22, 2016 at 03:17:23PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > On Mon, Sep 19, 2016 at 08:54:40PM +0200, Kevin Daudt wrote:
> >
> >> + ...
> >> + while ((c = *in++) != 0) {
> >> + if (take_next_literally) {
> >> + take_next_literally = 0;
> >> + } else {
> >> [...]
> >> + }
> >> +
> >> + strbuf_addch(line, c);
> >> + }
> >> +}
> >
> > It needs to `free(in)` at the end of the function.
>
> Ehh, in has been incremented and is pointing at the terminating NUL
> there, so it would be more like
>
> char *to_free, *in;
>
> to_free = strbuf_detach(line, NULL);
> in = to_free;
> ...
> while ((c = *in++)) {
> ...
> }
> free(to_free);
>
> I would think ;-).
Oops, yes. It is beginning to make the "strbuf_swap()" look less
convoluted. :)
-Peff
next prev parent reply other threads:[~2016-09-23 4:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 21:02 [PATCH] mailinfo: unescape quoted-pair in header fields Kevin Daudt
2016-09-16 22:22 ` Jeff King
2016-09-19 10:51 ` Kevin Daudt
2016-09-20 3:57 ` Jeff King
2016-09-21 16:07 ` Junio C Hamano
2016-09-19 18:54 ` [PATCH v2 0/2] Handle escape characters in From field Kevin Daudt
2016-09-25 21:08 ` [PATCH v3 1/2] t5100-mailinfo: replace common path prefix with variable Kevin Daudt
2016-09-25 21:08 ` [PATCH v3 2/2] mailinfo: unescape quoted-pair in header fields Kevin Daudt
2016-09-26 19:11 ` Junio C Hamano
2016-09-26 19:26 ` Junio C Hamano
2016-09-26 19:44 ` Kevin Daudt
2016-09-26 22:23 ` Junio C Hamano
2016-09-27 10:26 ` Kevin Daudt
2016-09-26 19:06 ` [PATCH v3 1/2] t5100-mailinfo: replace common path prefix with variable Junio C Hamano
2016-09-28 19:49 ` [PATCH v4 0/2] Handle RFC2822 quoted-pairs in From header Kevin Daudt
2016-09-28 19:52 ` [PATCH v4 1/2] t5100-mailinfo: replace common path prefix with variable Kevin Daudt
2016-09-28 20:21 ` Junio C Hamano
2016-09-28 20:27 ` Kevin Daudt
2016-09-28 19:52 ` [PATCH v4 2/2] mailinfo: unescape quoted-pair in header fields Kevin Daudt
2016-09-19 18:54 ` [PATCH v2 1/2] t5100-mailinfo: replace common path prefix with variable Kevin Daudt
2016-09-19 21:16 ` Junio C Hamano
2016-09-20 3:59 ` Jeff King
2016-09-19 18:54 ` [PATCH v2 2/2] mailinfo: unescape quoted-pair in header fields Kevin Daudt
2016-09-19 21:24 ` Junio C Hamano
2016-09-19 22:04 ` Junio C Hamano
2016-09-20 4:28 ` Jeff King
2016-09-21 11:09 ` Jeff King
2016-09-22 22:17 ` Junio C Hamano
2016-09-23 4:15 ` Jeff King [this message]
2016-09-25 20:17 ` Kevin Daudt
2016-09-25 22:38 ` Jakub Narębski
2016-09-26 5:02 ` Kevin Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923041540.5fvl6ytp2tvcflsk@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ikke.info \
--cc=swiftgeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).