From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.3 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id C51AD1F935 for ; Wed, 21 Sep 2016 22:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934021AbcIUWWL (ORCPT ); Wed, 21 Sep 2016 18:22:11 -0400 Received: from cloud.peff.net ([104.130.231.41]:46371 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932337AbcIUWWL (ORCPT ); Wed, 21 Sep 2016 18:22:11 -0400 Received: (qmail 22225 invoked by uid 109); 21 Sep 2016 22:22:10 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Wed, 21 Sep 2016 22:22:10 +0000 Received: (qmail 3822 invoked by uid 111); 21 Sep 2016 22:22:23 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Wed, 21 Sep 2016 18:22:23 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 21 Sep 2016 18:22:08 -0400 Date: Wed, 21 Sep 2016 18:22:08 -0400 From: Jeff King To: Eric Wong Cc: Junio C Hamano , Yaroslav Halchenko , git@vger.kernel.org Subject: Re: [PATCH 4/3] http: check curl_multi_remove_handle error code Message-ID: <20160921222208.ccgnpgx3gcvbjpfm@sigill.intra.peff.net> References: <20160913002557.10671-1-e@80x24.org> <20160921214623.GA1919@whir> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160921214623.GA1919@whir> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Sep 21, 2016 at 09:46:23PM +0000, Eric Wong wrote: > -----------8<----------- > Subject: [PATCH] http: check curl_multi_remove_handle error code > > This should help detect bugs in future changes. While we're at > it, fix a (probably innocuous) bug in our http_cleanup function > for users of older curl. > > curl_multi_remove_handle was not idempotent until curl 7.33.0 > with commit 84f3b3dd448399f9548468676e1bd1475dba8de5 > ("curl_multi_remove_handle: allow multiple removes"), > so we track the "curlm" membership of the curl easy handle > ourselves with a new "in_multi" flag. Does curl provide a meaningful error here? I'm just wondering if we could simply let curl handle this, and just ignore the error that comes from older versions. We're basically just replicating curl's own state data here. -Peff