From: John Keeping <john@keeping.me.uk>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Jonas Thiel <jonas.lierschied@gmx.de>, git@vger.kernel.org
Subject: Re: Re: Homebrew and Git
Date: Tue, 20 Sep 2016 20:15:55 +0100 [thread overview]
Message-ID: <20160920191555.GB1673@john.keeping.me.uk> (raw)
In-Reply-To: <20160920110700.GB64315@book.hvoigt.net>
On Tue, Sep 20, 2016 at 01:07:00PM +0200, Heiko Voigt wrote:
> On Tue, Sep 20, 2016 at 01:02:28PM +0200, Heiko Voigt wrote:
> > Hi,
> >
> > On Sun, Sep 18, 2016 at 05:50:28PM +0200, Jonas Thiel wrote:
> > > A while ago I have described my problem with Homebrew at the following
> > > GitHub channel
> > > (https://github.com/Homebrew/homebrew-core/issues/2970). In the
> > > meanwhile, I believe that I my problem with Homebrew is based on an
> > > issues with my Git. I have found the attached Git Crash reports on my
> > > Mac and because I am not familiar with reading/analysing Crash
> > > Reports, it would be great if someone could give me some feedback on
> > > it.
> > >
> > > If you have any question, please do not hesitate to contact me.
> >
> > From your crash reports I see that git is apparently crashing in a
> > strchr() call from within ident_default_email() which is a function that
> > tries to assemble a name and email to put into your commits.
>
> BTW, here is the callstack inlined from the crashreport:
>
> bsystem_platform.dylib 0x00007fff840db41c _platform_strchr$VARIANT$Haswell + 28
> 1 git 0x000000010ba1d3f4 ident_default_email + 801
> 2 git 0x000000010ba1d68f fmt_ident + 66
> 3 git 0x000000010ba4b495 files_log_ref_write + 175
> 4 git 0x000000010ba4b0a6 commit_ref_update + 106
> 5 git 0x000000010ba4c3a8 ref_transaction_commit + 468
> 6 git 0x000000010b994dd8 s_update_ref + 271
> 7 git 0x000000010b994556 fetch_refs + 1969
> 8 git 0x000000010b9935f2 fetch_one + 1913
> 9 git 0x000000010b992bc4 cmd_fetch + 549
> 10 git 0x000000010b9666c4 handle_builtin + 478
> 11 git 0x000000010b96602f main + 376
> 12 libdyld.dylib 0x00007fff834ef5ad start + 1
>
> Maybe someone else has an idea what might be causing this...
The only strchr I can see that could be called here is in
canonical_name(), where it's called with addrinfo::ai_canonname.
Searching for OS X and ai_canonname, leads me straight back to this
list, although 7 years ago! I think ident.c needs a fix similar to
commit 3e8a00a (daemon.c: fix segfault on OS X, 2009-04-27); from the
commit message there:
On OS X (and maybe other unices), getaddrinfo(3) returns NULL
in the ai_canonname field if it's called with an IP address for
the hostname.
next prev parent reply other threads:[~2016-09-20 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 15:50 Homebrew and Git Jonas Thiel
2016-09-20 11:02 ` Heiko Voigt
2016-09-20 11:07 ` Heiko Voigt
2016-09-20 19:15 ` John Keeping [this message]
2016-09-21 8:48 ` Jeff King
2016-09-22 9:23 ` Aw: " Jonas Thiel
2016-09-22 15:57 ` Stefan Beller
2016-09-23 4:07 ` Jeff King
2016-09-23 4:37 ` [PATCH] ident: handle NULL ai_canonname Jeff King
2016-09-20 18:45 ` Aw: Re: Homebrew and Git Jonas Thiel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920191555.GB1673@john.keeping.me.uk \
--to=john@keeping.me.uk \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=jonas.lierschied@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).