From: Heiko Voigt <hvoigt@hvoigt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Stefan Beller <sbeller@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Jens Lehmann <Jens.Lehmann@web.de>,
Fredrik Gustafsson <iveqy@iveqy.com>,
Leandro Lucarella <leandro.lucarella@sociomantic.com>
Subject: Re: [PATCH 1/2] serialize collection of changed submodules
Date: Mon, 19 Sep 2016 21:44:29 +0200 [thread overview]
Message-ID: <20160919194412.GA62429@book.hvoigt.net> (raw)
In-Reply-To: <xmqqintvlpqv.fsf@gitster.mtv.corp.google.com>
On Fri, Sep 16, 2016 at 10:27:04AM -0700, Junio C Hamano wrote:
> Heiko Voigt <hvoigt@hvoigt.net> writes:
>
> > +static struct sha1_array *get_sha1s_from_list(struct string_list *submodules,
> > + const char *path)
> > +{
> > + struct string_list_item *item;
> > + struct sha1_array *hashes;
> > +
> > + item = string_list_insert(submodules, path);
> > + if (item->util)
> > + return (struct sha1_array *) item->util;
> > +
> > + hashes = (struct sha1_array *) xmalloc(sizeof(struct sha1_array));
> > + /* NEEDSWORK: should we add an initializer function for
> > + * sha1_array ? */
> > + memset(hashes, 0, sizeof(struct sha1_array));
> > + item->util = hashes;
>
>
> /* NEEDSWORK: should we have SHA1_ARRAY_INIT etc.? */
> item->util = xcalloc(1, sizeof(struct sha1_array));
Ok will do.
next prev parent reply other threads:[~2016-09-19 19:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 17:30 [PATCHv2] push: change submodule default to check Stefan Beller
2016-08-24 18:38 ` Junio C Hamano
[not found] ` <20160824183112.ceekegpzavnbybxp@sigill.intra.peff.net>
2016-08-24 19:37 ` Junio C Hamano
2016-08-24 21:26 ` Junio C Hamano
2016-08-24 22:37 ` Stefan Beller
2016-08-24 23:01 ` Jeff King
2016-09-14 17:31 ` [PATCH 1/2] serialize collection of changed submodules Heiko Voigt
2016-09-14 22:30 ` Junio C Hamano
2016-09-15 12:10 ` [PATCH 3/2] batch check whether submodule needs pushing into one call Heiko Voigt
2016-09-15 21:08 ` Junio C Hamano
2016-09-16 9:40 ` Heiko Voigt
2016-09-16 12:31 ` Heiko Voigt
2016-09-16 18:13 ` Junio C Hamano
2016-09-19 20:08 ` Heiko Voigt
2016-09-16 17:59 ` Junio C Hamano
2016-09-19 19:58 ` Heiko Voigt
2016-09-15 12:18 ` [PATCH 4/2] use actual start hashes for submodule push check instead of local refs Heiko Voigt
2016-09-16 17:27 ` [PATCH 1/2] serialize collection of changed submodules Junio C Hamano
2016-09-19 19:44 ` Heiko Voigt [this message]
2016-09-14 17:51 ` [PATCH 2/2] serialize collection of refs that contain submodule changes Heiko Voigt
2016-09-14 19:46 ` Heiko Voigt
2016-09-14 20:04 ` Stefan Beller
2016-09-16 17:47 ` Junio C Hamano
2016-09-19 19:51 ` Heiko Voigt
2016-09-19 20:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919194412.GA62429@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=iveqy@iveqy.com \
--cc=leandro.lucarella@sociomantic.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).