From: Eric Wong <e@80x24.org>
To: Yaroslav Halchenko <yoh@onerussian.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: [RFC 0/3] http: avoid repeatedly adding curl easy to curlm
Date: Tue, 13 Sep 2016 00:25:54 +0000 [thread overview]
Message-ID: <20160913002557.10671-1-e@80x24.org> (raw)
In-Reply-To: <20160909221942.GS9830@onerussian.com>
(I have some hours online today, so I decided to work on this)
The key patch here is 3/3 which seems like an obvious fix to
adding the problem of adding a curl easy handle to a curl multi
handle repeatedly.
What is unclear to me is how only Yaroslav's repository seems to
trigger this bug after all these years...
However, I am fairly sure this fixes the bug Yaroslav
encountered. This patch series is also needed for 2.9.3 and
perhaps older maintenance tracks for distros.
In PATCH 2/3, I originally had error checking, but removed it
after noticing it was causing failures on wheezy.
I will investigate those failures in a week or two when I regain
regular computer access.
These patches are needed for 2.9.x (and probably earlier), too.
The following changes since commit cda1bbd474805e653dda8a71d4ea3790e2a66cbb:
Sync with maint (2016-09-08 22:00:53 -0700)
are available in the git repository at:
git://bogomips.org/git-svn.git dumb-http-release
for you to fetch changes up to 3f561d0f0f78fd841708b5e81122e9d825919fd3:
http: always remove curl easy from curlm session on release (2016-09-12 23:59:35 +0000)
----------------------------------------------------------------
Eric Wong (3):
http: warn on curl_multi_add_handle failures
http: consolidate #ifdefs for curl_multi_remove_handle
http: always remove curl easy from curlm session on release
http.c | 29 ++++++++++++++++++-----------
1 file changed, 18 insertions(+), 11 deletions(-)
--
EW
next prev parent reply other threads:[~2016-09-13 0:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 22:19 git clone http:// fails some times with "Request for d53.. aborted" Yaroslav Halchenko
2016-09-10 0:21 ` Eric Wong
2016-09-13 0:25 ` Eric Wong [this message]
2016-09-13 0:25 ` [RFC 1/3] http: warn on curl_multi_add_handle failures Eric Wong
2016-09-13 0:25 ` [RFC 2/3] http: consolidate #ifdefs for curl_multi_remove_handle Eric Wong
2016-09-13 0:25 ` [RFC 3/3] http: always remove curl easy from curlm session on release Eric Wong
2016-09-13 20:32 ` [RFC 0/3] http: avoid repeatedly adding curl easy to curlm Junio C Hamano
2016-09-21 21:46 ` [PATCH 4/3] http: check curl_multi_remove_handle error code Eric Wong
2016-09-21 22:22 ` Jeff King
2016-09-21 22:29 ` Eric Wong
2016-09-21 22:31 ` Jeff King
2016-09-14 11:59 ` [RFC 0/3] http: avoid repeatedly adding curl easy to curlm Yaroslav Halchenko
2016-09-14 14:03 ` git submodule add spits unrelated to actual problem error msg about .gitignore Yaroslav Halchenko
2016-09-14 19:32 ` Stefan Beller
2016-09-14 20:23 ` Yaroslav Halchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913002557.10671-1-e@80x24.org \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=yoh@onerussian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).