From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, Johannes Sixt <j6t@kdbg.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t6026-merge-attr: wait for process to release trash directory
Date: Thu, 8 Sep 2016 04:27:13 -0400 [thread overview]
Message-ID: <20160908082713.sgzp2evbvzuthdb4@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1609081002490.129229@virtualbox>
On Thu, Sep 08, 2016 at 10:05:58AM +0200, Johannes Schindelin wrote:
> > > Is fifo safe on Windows, though?
> >
> > No clue. We seem to use mkfifo unconditionally in lib-daemon, but
> > perhaps people do not run that test on Windows. Other invocations seem
> > to be protected by the PIPE prerequisite. But...
>
> AFAICT we do not use mkfifo on Windows. Let's see what t/test-lib.sh has
> to say about the matter:
>
> test_lazy_prereq PIPE '
> # test whether the filesystem supports FIFOs
> case $(uname -s) in
> CYGWIN*|MINGW*)
> false
> ;;
> *)
> rm -f testfifo && mkfifo testfifo
> ;;
> esac
> '
>
> So there you go.
>
> The reason it is disabled is that Cygwin/MSYS2 do have a concept of a
> FIFO. But `git.exe` won't be able to access such a FIFO because it is
> emulated by the POSIX emulation layer, which Git cannot access.
Regarding my "unconditionally" above: coincidentally, I happened to be
looking in lib-git-daemon.sh about an hour ago and noticed that we do
indeed check "test_have_prereq PIPE" (just not near the mkfifo, of
course, because we are not in a test block).
It seems to have been added by a "Johannes Schindelin". Any relation?
So yeah. It definitely would be a bad idea to use a fifo in a test that
is already Windows-specific.
-Peff
next prev parent reply other threads:[~2016-09-08 8:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 19:03 [PATCH] t6026-merge-attr: wait for process to release trash directory Johannes Sixt
2016-09-06 7:25 ` Johannes Schindelin
2016-09-07 6:10 ` [PATCH v2] t6026-merge-attr: clean up background process at end of test case Johannes Sixt
2016-09-07 11:35 ` Johannes Schindelin
2016-09-06 7:27 ` [PATCH] t6026-merge-attr: wait for process to release trash directory Jeff King
2016-09-07 18:39 ` Junio C Hamano
2016-09-07 19:00 ` Jeff King
2016-09-07 19:59 ` Junio C Hamano
2016-09-08 8:05 ` Johannes Schindelin
2016-09-08 8:27 ` Jeff King [this message]
2016-09-09 9:58 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908082713.sgzp2evbvzuthdb4@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).