On Mon, Aug 29, 2016 at 05:43:41PM +0200, Johannes Schindelin wrote: > Hi Kuba, > > On Mon, 29 Aug 2016, Jakub Narębski wrote: > > > I wonder if writing this patch series (or rather the following one) > > would be helped by using one of semantic patch tools, such as > > Coccinelle[1], spdiff[2], or Undebt[3]... > > > > [1]: http://coccinelle.lip6.fr/ > > If previous work by Brian is any indication, he did use Coccinelle and the > commit message actually shows the definition used for the transformation. Yes, that is the case. I used Coccinelle because it's been used with success on LKML and it seems to work for the job. I'll make a note in the future that it obviously the semantic patch doesn't include the actual struct change. My goal with using a tool is that it's less error-prone and it helps reviewers have more confidence in the changes. Also, it makes large changes far less tedious. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204