From: Josh Triplett <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: firstname.lastname@example.org Subject: Re: upload-pack/ls-remote: showing non-HEAD symbolic refs? Date: Tue, 16 Aug 2016 13:31:50 -0700 [thread overview] Message-ID: <20160816203150.GA16774@cloud> (raw) In-Reply-To: <email@example.com> On Tue, Aug 16, 2016 at 02:28:52PM -0400, Jeff King wrote: > On Tue, Aug 16, 2016 at 10:34:44AM -0700, Josh Triplett wrote: > > > > Sadly you cannot use a capability to fix that, because all of this > > > happens before the client agrees to any capabilities (you can find > > > discussion of a "v2" protocol on the list which solves this, but it's > > > sort of languishing in the design phase). > > > > As a potential 1.1 version, which could work in a backward-compatible > > way with existing servers and no additional round-trip: what if, in the > > smart HTTP protocol, the client advertised client capabilities with an > > additional HTTP header (e.g. "Git-Client-Caps: symrefs othershiny > > featurenames"? git-http-backend could then pass those capabilities to > > git-upload-pack (--client-caps='...'), which could take them into > > account in the initial response? > > > > That wouldn't work as a single-pass approach for SSH, since the client > > can't know if the server's upload-pack supports --client-caps, but it > > would work for the smart HTTP protocol. > > You can dig up the discussion on the list under the name "protocol v2", > but basically yes, that approach has been considered. It's a little > gross just because it leaves other protocols behind http (and it is not > necessarily a good idea to push people into http, because it has some > fundamental drawbacks over the other protocols because of its > half-duplex nature). I looked through the "protocol v2" threads, but couldn't find any discussions of using HTTP headers. I found some mentions of using additional query parameters on the git-upload-pack request, which would break compatibility with existing servers (they won't just ignore the extra parameter). --client-caps could work for SSH as well, it just requires an extra round-trip to check for --client-caps. Call git-upload-pack --supports-client-caps, ignore any output (which with current git will consist of a usage message), see if it returns a 0 exit code, if so, call git-upload-pack --client-caps='...', and if not just call git-upload-pack. (A new git-upload-pack-2 binary would also work, but that seems like overkill.) I don't see any way around the extra round trip here that would preserve backward compatibility with existing SSH servers (which may force clients to *only* run exactly the command "git-upload-pack" and nothing else). Another possibility, which would work for both HTTPS and git-protocol-over-TLS, would be to use ALPN. git:// , however, would require a new service name, and that service would have to accept client caps in-band. That doesn't seem nearly as important to support, though. And that approach doesn't seem preferable for HTTP, which would require modification to server configuration to support the new path rather than an HTTP header to the existing path.
next prev parent reply other threads:[~2016-08-16 20:32 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-16 16:18 Josh Triplett 2016-08-16 16:31 ` Jeff King 2016-08-16 17:34 ` Josh Triplett 2016-08-16 18:28 ` Jeff King 2016-08-16 18:50 ` Stefan Beller 2016-08-16 20:34 ` Josh Triplett 2016-08-16 20:31 ` Josh Triplett [this message] 2016-08-16 20:54 ` Jeff King 2016-08-16 21:11 ` Josh Triplett 2016-08-16 21:15 ` Jeff King 2016-08-16 22:24 ` Josh Triplett 2016-08-19 13:47 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160816203150.GA16774@cloud \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: upload-pack/ls-remote: showing non-HEAD symbolic refs?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).