From: Christian Hesse <list@eworm.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH 1/1] do not add common-main to lib
Date: Mon, 15 Aug 2016 14:30:07 +0200 [thread overview]
Message-ID: <20160815143007.2225c655@leda.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.20.1608151418150.4924@virtualbox>
[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]
Johannes Schindelin <Johannes.Schindelin@gmx.de> on Mon, 2016/08/15 14:20:
> Hi Christian,
>
> On Mon, 15 Aug 2016, Christian Hesse wrote:
>
> > From: Christian Hesse <mail@eworm.de>
> >
> > Commit 08aade70 (mingw: declare main()'s argv as const) changed
> > declaration of main function. This breaks linking external projects
> > (e.g. cgit) to libgit.a with:
> >
> > error: Multiple definition of `main'
> >
> > So do not add common-main to lib and let projects have their own
> > main function.
>
> I am opposed to this change.
Me too. :-p
> For one, libgit.a is *not* a library with an API, for a good reason:
> nothing in Git's development guarantees any kind of stable API. For that
> reason, libgit.a is not installed, either, and neither are any headers.
>
> And even more importantly: *iff* you *insist* on using libgit.a in your
> project *despite* having been told not to, it is your responsibility to
> stay up-to-date with the requirements of it.
cgit pulls in the git tree as a subproject. We are aware that the API changes
all the time and that's fine. Usually we just fix it, this time I missed the
background information of the change.
> One such requirement is that you now implement cmd_main() instead of
> main().
>
> So if you want to continue to have an out-of-tree project that links
> against the (private) libgit.a, it is your out-of-tree project that needs
> changing, not libgit.a.
Already updated my code. ;)
Thanks!
--
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];)
putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-08-15 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 7:52 [PATCH 1/1] do not add common-main to lib Christian Hesse
2016-08-15 12:02 ` Jeff King
2016-08-15 12:21 ` Christian Hesse
2016-08-15 12:20 ` Johannes Schindelin
2016-08-15 12:30 ` Christian Hesse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815143007.2225c655@leda.localdomain \
--to=list@eworm.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mail@eworm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).