From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] correct FLEXPTR_* example in comment
Date: Sat, 13 Aug 2016 14:36:40 -0400 [thread overview]
Message-ID: <20160813183640.axpnjj44bteraevi@sigill.intra.peff.net> (raw)
In-Reply-To: <57AF582A.3050406@web.de>
On Sat, Aug 13, 2016 at 07:26:02PM +0200, René Scharfe wrote:
> > I suppose it could assert(sizeof((x)->flexname) == FLEX_ALLOC) or
> > something, but I'm not sure if it is worth worrying about.
>
> You can't use sizeof with an actual flexible array. It only works if
> FLEX_ARRAY is defined as 1 (for platforms without native support), and
> perhaps also if it's 0.
>
> offsetof(struct x, arr) == sizeof(struct x) won't work either because of
> padding.
>
> I have no idea what you can do with a flexible array that would throw a
> compile error when done with a pointer.
Thanks for the input. I'd say we should not worry about it. The reason
this particular "bug" persisted is because it was in a comment. People
tend to notice code that cannot possibly do anything but segfault before
they even send in patches.
-Peff
prev parent reply other threads:[~2016-08-14 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 9:01 [PATCH] correct FLEXPTR_* example in comment René Scharfe
2016-08-13 9:09 ` Jeff King
2016-08-13 9:19 ` René Scharfe
2016-08-13 17:26 ` René Scharfe
2016-08-13 18:36 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160813183640.axpnjj44bteraevi@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).