From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] commit: introduce set_merge_remote_desc()
Date: Sat, 13 Aug 2016 08:24:51 -0400 [thread overview]
Message-ID: <20160813122451.vrqqjjpqicqtz2uj@sigill.intra.peff.net> (raw)
In-Reply-To: <57AF0D8E.6040309@web.de>
On Sat, Aug 13, 2016 at 02:07:42PM +0200, René Scharfe wrote:
> So let's turn this dish into a full menu:
>
> commit: use xstrdup() in get_merge_parent()
> commit: factor out set_merge_remote_desc()
> merge-recursive: fix verbose output for multiple base trees
> commit: use FLEX_ARRAY in struct merge_remote_desc
Very nice. Four patches seems like a lot for such a small fix, but each
one is so trivial and easy to understand, I think it's worth it.
They all look good to me.
-Peff
prev parent reply other threads:[~2016-08-13 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 9:14 [PATCH] commit: introduce set_merge_remote_desc() René Scharfe
2016-08-13 9:23 ` Jeff King
2016-08-13 12:07 ` René Scharfe
2016-08-13 12:09 ` [PATCH v2 1/4] commit: use xstrdup() in get_merge_parent() René Scharfe
2016-08-13 12:11 ` [PATCH v2 2/4] commit: factor out set_merge_remote_desc() René Scharfe
2016-08-13 12:16 ` [PATCH v2 3/4] merge-recursive: fix verbose output for multiple base trees René Scharfe
2016-08-13 12:21 ` [PATCH v2 4/4] commit: use FLEX_ARRAY in struct merge_remote_desc René Scharfe
2016-08-13 12:24 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160813122451.vrqqjjpqicqtz2uj@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).