From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: gitster@pobox.com, jrnieder@gmail.com, git@vger.kernel.org,
remi.galan-alfonso@ensimag.grenoble-inp.fr
Subject: Re: [PATCHv3] checkout: do not mention detach advice for explicit --detach option
Date: Fri, 12 Aug 2016 11:43:31 -0400 [thread overview]
Message-ID: <20160812154331.y2z6pv2w6cwsdsqw@sigill.intra.peff.net> (raw)
In-Reply-To: <20160812153744.15045-1-sbeller@google.com>
On Fri, Aug 12, 2016 at 08:37:44AM -0700, Stefan Beller wrote:
> > Is there a reason for not unsetting `advice.detachedHead` at the
> > end of the test?
>
> done
>
> I did not consider to clean up after myself... what a selfish world!
The right way to do it is:
test_config advice.detachedHead false &&
...
so that the cleanup runs whether or not you may it to the end of the
script.
> +test_expect_success 'no advice given for explicit detached head state' '
> + git config advice.detachedHead false &&
> + git checkout child &&
> + git checkout --detach HEAD >expect &&
> + git config advice.detachedHead true &&
> + git checkout child &&
> + git checkout --detach HEAD >actual &&
> + test_cmp expect actual &&
> + git checkout child &&
> + git checkout HEAD >actual &&
> + ! test_cmp expect actual &&
> + git config --unset advice.detachedHead
> +'
Hmm. Using "!test_cmp" seems weird to me, just because it would falsely
claim success if something else unexpected changes. Our usual method for
making sure some particular output does not appear is "test_i18ngrep"
with a liberal pattern.
-Peff
next prev parent reply other threads:[~2016-08-12 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 15:37 [PATCHv3] checkout: do not mention detach advice for explicit --detach option Stefan Beller
2016-08-12 15:43 ` Jeff King [this message]
2016-08-12 15:51 ` Stefan Beller
2016-08-12 16:28 ` Jeff King
2016-08-12 16:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812154331.y2z6pv2w6cwsdsqw@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).