From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 293462018E for ; Fri, 5 Aug 2016 18:47:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758999AbcHESq6 (ORCPT ); Fri, 5 Aug 2016 14:46:58 -0400 Received: from dcvr.yhbt.net ([64.71.152.64]:52140 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbcHESq5 (ORCPT ); Fri, 5 Aug 2016 14:46:57 -0400 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B3DF12018E; Fri, 5 Aug 2016 18:46:56 +0000 (UTC) Date: Fri, 5 Aug 2016 18:46:56 +0000 From: Eric Wong To: Johannes Schindelin Cc: Stefan Beller , Junio C Hamano , Git Mailing List , Eric Sunshine , Jeff King , Johannes Sixt , Duy Nguyen , Jakub =?utf-8?B?TmFyxJlic2tp?= Subject: Re: patch submission process, was Re: [PATCH v6 06/16] merge_recursive: abort properly upon errors Message-ID: <20160805184656.GA463@starla> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Johannes Schindelin wrote: > On Thu, 4 Aug 2016, Stefan Beller wrote: > > git send-email/format-patch recently learned to include a base commit > > You may have noticed that my mail-patch-series.sh-generated code > submissions contain that base commit. But they still do not contain the > SHA-1s of my local commits corresponding to the patches, and even if they > did, the replies with suggested edits would most likely have lost said > information. > > I also hate to break it to you that git-send-email is not going to be part > of any solution. I think it ought to be. Some reasons I like emailing patches are: * there's no taking it back once it's sent * it's backed up within seconds by thousands of subscribers :) * doesn't require the reader to have an active connection to fetch out-of-band * doesn't require the reader to be on the same machine capable of cloning/building the project There are times when I've been on a slow machine, or offline when I wanted to read some patches. However, I do like including a pull request in cover letters of a patch series (not necessary for one-offs). But on a side note, I also find it depressing that SMTP is uncompressed and TLS compression is (still?) unsafe. At least I use ssh tunnels w/ compression for IMAP/SMTP to my own server.