git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Eric Wong <e@80x24.org>, Junio C Hamano <gitster@pobox.com>,
	"Kyle J. McKay" <mackyle@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] pager: move pager-specific setup into the build
Date: Mon, 1 Aug 2016 13:52:17 -0400	[thread overview]
Message-ID: <20160801175216.payv2zrc3mkvkbmz@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8AEFFTnGw01mTBrZu8QnUWmQav7bhZUyw7o91ph7DUwaA@mail.gmail.com>

On Mon, Aug 01, 2016 at 07:46:34PM +0200, Duy Nguyen wrote:

> On Mon, Aug 1, 2016 at 3:05 AM, Eric Wong <e@80x24.org> wrote:
> > From: Junio C Hamano <gitster@pobox.com>
> >
> > Allowing PAGER_ENV to be set at build-time allows us to move
> > pager-specific knowledge out of our build.  Currently, this
> > allows us to set a better default for FreeBSD where more(1)
> > is the same binary as less(1).
> 
> Nice. I was just too lazy to do something like this and "export
> PAGER=less LESS=FRX" then ignored it :-P
> 
> Slightly off topic, but pagers like 'more' does not understand colors
> either. But color.ui = auto does not know what and prints color code
> anyway. It would be nice if we had some configuration to describe
> "this pager can show colors, that pager does not" so I don't have to
> maintain separate .gitconfig files on two platforms.

If you are interested, I suggest you read the thread linked earlier:

  https://public-inbox.org/git/52D87A79.6060600%40rawbw.com/T/#u

which discusses this and other issues. But basically, I think you cannot
really solve this without getting intimate with each pager (which people
seemed not to want to do).

-Peff

  reply	other threads:[~2016-08-01 17:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01  1:05 [PATCH 0/2] add PAGER_ENV to build and core.pagerEnv to config Eric Wong
2016-08-01  1:05 ` [PATCH 1/2] pager: move pager-specific setup into the build Eric Wong
2016-08-01  1:43   ` brian m. carlson
2016-08-01  7:00     ` Eric Wong
2016-08-01  8:57       ` Jakub Narębski
2016-08-01 10:40         ` brian m. carlson
2016-08-01 17:24     ` Jeff King
2016-08-01 18:07       ` Junio C Hamano
2016-08-01 17:46   ` Duy Nguyen
2016-08-01 17:52     ` Jeff King [this message]
2016-08-01 18:01       ` Duy Nguyen
2016-08-01 18:07         ` Jeff King
2016-08-01  1:05 ` [PATCH 2/2] pager: implement core.pagerEnv in config Eric Wong
2016-08-01 17:28   ` Jeff King
2016-08-01 21:49 ` [PATCH 0/1 v2] add PAGER_ENV to build Eric Wong
2016-08-01 21:49   ` [PATCH 1/1 v2] pager: move pager-specific setup into the build Eric Wong
2016-08-01 23:03     ` Junio C Hamano
2016-08-01 23:46       ` Jeff King
2016-08-02 21:14         ` Junio C Hamano
2016-08-01 23:56       ` Eric Wong
2016-08-02 21:15         ` Junio C Hamano
2016-08-03 16:19     ` Jeff King
2016-08-03 20:57       ` Junio C Hamano
2016-08-03 21:08         ` Eric Wong
2016-08-03 21:15           ` Junio C Hamano
2016-08-04  3:43             ` [PATCH v3] " Eric Wong
2016-08-04  5:34               ` Jeff King
2016-08-04 11:34                 ` Eric Wong
2016-08-04 17:53                   ` Jeff King
2016-08-04 11:40               ` [PATCH v4] " Eric Wong
2016-08-03 21:09         ` [PATCH 1/1 v2] " Jeff King
2016-08-01 21:59   ` [PATCH 0/1 v2] add PAGER_ENV to build Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160801175216.payv2zrc3mkvkbmz@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mackyle@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).