From: Josh Triplett <josh@joshtriplett.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC] git-format-patch: default to --from to avoid spoofed mails?
Date: Thu, 28 Jul 2016 17:05:07 -0700 [thread overview]
Message-ID: <20160729000507.GA3149@x> (raw)
In-Reply-To: <xmqq8twlqwan.fsf@gitster.mtv.corp.google.com>
On Thu, Jul 28, 2016 at 02:37:04PM -0700, Junio C Hamano wrote:
> Josh Triplett <josh@joshtriplett.org> writes:
>
> > I'd like to propose changing the default behavior of git-format-patch to
> > --from (and adding a --from-author option to override, and perhaps a
> > config setting). This will not change the output *except* when
> > formatting patches authored by someone else. git-am and git-send-email
> > both handle the --from format without any issues.
>
> I see this in "format-patch --help":
>
> Note that this option is only useful if you are actually
> sending the emails and want to identify yourself as the
> sender, but retain the original author (and git am will
> correctly pick up the in-body header). Note also that
> git send-email already handles this transformation for
> you, and this option should not be used if you are
> feeding the result to git send-email.
>
> The first one says "only useful", but it seems what it really means
> is "it becomes no-op if you are sending your own patch anyway". So
> that one does not worry me. What is most worrysome is the latter
> half of the last sentence. Is it really "should not be", or is it
> merely "use of this option is just a waste of time, as you would get
> exactly the same result anyway"? If it is the latter, that is fine.
As far as I can tell, it's the latter. git send-email can do this same
transformation, but handles mails that already have the transformation
done to them without any issue.
> One thing I absolutely do not want to see is people to start
> repeating their own ident on in-body "From: " header when they send
> their own patch. That would waste everybody's time pointing out
> "You do not have to do that, it merely adds noise". As long as you
> can guarantee that your change won't increase the rate of that, I am
> fine with the proposal.
git format-patch with --from *only* adds an in-body "From:" if the
commit author differs from the local committer identity. So, as far as
I can tell, the only scenario that would produce additional in-body "From:"
headers here would be if someone had failed to configure their git
identity, and manually set the author for their own commits. (In which
case, they'd also have a broken "From:" in any cover letter they
generated.)
So, it seems exceedingly unlikely to me that this would result in
unnecessary in-body "From:" headers.
- Josh Triplett
next prev parent reply other threads:[~2016-07-29 0:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 21:11 [RFC] git-format-patch: default to --from to avoid spoofed mails? Josh Triplett
2016-07-28 21:37 ` Junio C Hamano
2016-07-28 21:56 ` Jeff King
2016-07-28 22:14 ` Junio C Hamano
2016-07-28 23:53 ` Josh Triplett
2016-07-29 0:17 ` Jeff King
2016-07-29 0:16 ` Jeff King
2016-07-29 2:08 ` Josh Triplett
2016-07-29 22:58 ` Jeff King
2016-07-30 4:50 ` Josh Triplett
2016-07-30 5:47 ` Jeff King
2016-07-30 5:57 ` Josh Triplett
2016-07-30 9:41 ` [PATCH 0/2] format-patch: Transition the default to --from to avoid spoofed mails Josh Triplett
2016-08-01 17:35 ` [RFC] git-format-patch: default to --from to avoid spoofed mails? Junio C Hamano
2016-08-01 17:43 ` Jeff King
2016-08-01 18:59 ` Junio C Hamano
2016-07-29 0:04 ` Josh Triplett
2016-07-29 0:05 ` Josh Triplett [this message]
2016-07-29 16:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729000507.GA3149@x \
--to=josh@joshtriplett.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).