From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] revert: clarify seemingly bogus OPT_END repetition
Date: Wed, 6 Jul 2016 06:48:00 -0400 [thread overview]
Message-ID: <20160706104800.GA28798@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1607060901430.6426@virtualbox>
On Wed, Jul 06, 2016 at 09:03:44AM +0200, Johannes Schindelin wrote:
> > By the way, I notice that the error message when concat fails is just:
> >
> > if (parse_options_concat(options, ARRAY_SIZE(options), cp_extra))
> > die(_("program error"));
> >
> > Should this become:
> >
> > die("BUG: not enough room to concatenate options");
> >
> > as part of your BUG cleanups elsewhere?
>
> Not really. I do not have time for a crusade through all of the die()
> statements to determine whether they're really bug reports. You refer to
> my clean-up of merge-recursive.c, right? That was a necessary prerequisite
> for the patch to stop die()ing in case of errors.
Yeah. I didn't look at it all that closely, but it looked like you hit
places outside of merge-recursive, too. I agree it is not worth
including unless you are crusading, though (and anyway, my patch gets
rid of the message entirely).
-Peff
prev parent reply other threads:[~2016-07-06 10:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 11:58 [PATCH] revert: clarify seemingly bogus OPT_END repetition Johannes Schindelin
2016-07-05 20:28 ` Jeff King
2016-07-05 20:44 ` Jeff King
2016-07-05 21:15 ` Jacob Keller
2016-07-06 7:01 ` Johannes Schindelin
2016-07-06 11:09 ` Michael J Gruber
2016-07-06 13:16 ` Over-/underquoting, was " Johannes Schindelin
2016-07-06 20:15 ` Jacob Keller
2016-07-09 15:34 ` Michael J Gruber
2016-07-09 23:35 ` Eric Wong
2016-07-06 7:28 ` Johannes Schindelin
2016-07-06 7:03 ` Johannes Schindelin
2016-07-06 10:48 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706104800.GA28798@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).