From: Eric Wong <e@80x24.org>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Mike Hommey <mh@glandium.org>,
Lars Schneider <larsxschneider@gmail.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [RFC/PATCH v2 00/10] Add initial experimental external ODB support
Date: Wed, 29 Jun 2016 20:01:42 +0000 [thread overview]
Message-ID: <20160629200142.GA17878@dcvr.yhbt.net> (raw)
In-Reply-To: <20160628181933.24620-1-chriscool@tuxfamily.org>
Christian Couder <christian.couder@gmail.com> wrote:
> Design discussion about performance
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Yeah, it is not efficient to fork/exec a command to just read or write
> one object to or from the external ODB. Batch calls and/or using a
> daemon and/or RPC should be used instead to be able to store regular
> objects in an external ODB. But for now the external ODB would be all
> about really big files, where the cost of a fork+exec should not
> matter much. If we later want to extend usage of external ODBs, yeah
> we will probably need to design other mechanisms.
I would also investigate switching run_command to use vfork+exec
or posix_spawn for performance (keeping in mind vfork
caveats documented at https://ewontfix.com/7/ )
posix_spawn in future glibc (probably 2.24) will use CLONE_VFORK
in all cases under Linux, and posix_spawn may help with
portability, too. I think the only thing we can't support
with posix_spawn which run_command supports is chdir;
all the redirections/closing FDs should be fine.
With only 10MB malloc-ed, the following shows vfork performance
being noticeably faster than plain fork:
/* gcc -o vfork-test -Wall -O2 vfork-test.c */
#include <sys/types.h>
#include <sys/wait.h>
#include <unistd.h>
#include <stdlib.h>
#include <string.h>
int main(int argc, char *argv[], char *envp[])
{
int i;
int do_vfork = argc > 1 && !strcmp(argv[1], "vfork");
char * const cmd[] = { "/bin/true", 0 };
size_t n = 1024 * 1024 * 10;
char *mem = malloc(n);
memset(mem, 'a', n); /* make sure it's really allocated */
for (i = 0; i < 10000; i++) {
pid_t pid = do_vfork ? vfork() : fork();
if (pid == 0) {
execve(cmd[0], cmd, envp);
write(2, "exec error\n", 11);
_exit(1);
}
waitpid(pid, 0, 0);
}
return 0;
}
next prev parent reply other threads:[~2016-06-29 20:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 18:19 [RFC/PATCH v2 00/10] Add initial experimental external ODB support Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 01/10] Add initial external odb support Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 02/10] external odb foreach Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 03/10] t0400: use --batch-all-objects to get all objects Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 04/10] t0400: add 'put' command to odb-helper script Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 05/10] t0400: add test for 'put' command Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 06/10] external odb: add write support Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 07/10] external-odb: accept only blobs for now Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 08/10] t0400: add test for external odb write support Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 09/10] Add GIT_NO_EXTERNAL_ODB env variable Christian Couder
2016-06-28 18:19 ` [RFC/PATCH v2 10/10] Add t0410 to test external ODB transfer Christian Couder
2016-06-29 20:01 ` Eric Wong [this message]
2016-06-30 9:49 ` [RFC/PATCH v2 00/10] Add initial experimental external ODB support Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629200142.GA17878@dcvr.yhbt.net \
--to=e@80x24.org \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=mh@glandium.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).