git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: gitster@pobox.com, git@vger.kernel.org,
	Jordan DE GEA <jordan.de-gea@ensimag.grenoble-inp.fr>,
	Samuel GROOT <samuel.groot@ensimag.grenoble-inp.fr>,
	Erwan MATHONIERE <erwan.mathoniere@ensimag.grenoble-inp.fr>,
	Tom RUSSELLO <tom.russello@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH 1/6] doc: typeset short command-line options as literal
Date: Mon, 27 Jun 2016 14:57:15 -0400	[thread overview]
Message-ID: <20160627185715.GB9594@sigill.intra.peff.net> (raw)
In-Reply-To: <20160627174623.11084-1-Matthieu.Moy@imag.fr>

On Mon, Jun 27, 2016 at 07:46:18PM +0200, Matthieu Moy wrote:

> It was common in our documentation to surround short option names with
> forward quotes, which renders as italic in HTML. Instead, use backquotes
> which renders as monospace. This is one more step toward conformance to
> Documentation/CodingGuidelines.
> 
> This was obtained with:
> 
>   perl -pi -e "s/'(-[a-z])'/\`\$1\`/g" *.txt

I think this is an improvement, assuming everyone is happy with the new
MAN_BOLD_LITERAL default.

I skimmed the diff and it looks there were no mis-conversions (I
recommend diff-highlight for this, as it makes it much easier to spot,
though perhaps --color-words would help, too).

> diff --git a/Documentation/git-mv.txt b/Documentation/git-mv.txt
> index e453132..cbae886 100644
> --- a/Documentation/git-mv.txt
> +++ b/Documentation/git-mv.txt
> @@ -35,7 +35,7 @@ OPTIONS
>          Skip move or rename actions which would lead to an error
>  	condition. An error happens when a source is neither existing nor
>  	controlled by Git, or when it would overwrite an existing
> -        file unless '-f' is given.
> +        file unless `-f` is given.

git-am complains about the space indentation in the post-image. I know
it was there before your patch, but the indentation for that paragraph
is off. I wonder if it makes sense to fix it as a preliminary patch.

-Peff

  parent reply	other threads:[~2016-06-27 18:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 17:46 [PATCH 1/6] doc: typeset short command-line options as literal Matthieu Moy
2016-06-27 17:46 ` [PATCH 2/6] doc: typeset long " Matthieu Moy
2016-06-27 19:04   ` Jeff King
2016-06-28  8:08     ` Matthieu Moy
2016-06-28 15:19       ` Junio C Hamano
2016-06-27 17:46 ` [PATCH 3/6] doc: typeset -- as litteral Matthieu Moy
2016-06-27 19:10   ` Jeff King
2016-06-28  8:26     ` Matthieu Moy
2016-06-27 17:46 ` [PATCH 4/6] doc: typeset long options with argument " Matthieu Moy
2016-06-27 17:46 ` [PATCH 5/6] CodingGuidelines: formatting HEAD in documentation Matthieu Moy
2016-06-27 17:46 ` [PATCH 6/6] doc: typeset HEAD and variants as litteral Matthieu Moy
2016-06-27 18:57 ` Jeff King [this message]
2016-06-28  8:31   ` [PATCH 1/6] doc: typeset short command-line options as literal Matthieu Moy
2016-06-28 11:40 ` [PATCH v2 0/7] literal formatting in documentation Matthieu Moy
2016-06-28 11:40   ` [PATCH v2 1/7] Documentation/git-mv.txt: fix whitespace indentation Matthieu Moy
2016-06-28 11:40   ` [PATCH v2 2/7] doc: typeset short command-line options as literal Matthieu Moy
2016-06-28 11:40   ` [PATCH v2 3/7] doc: typeset long " Matthieu Moy
2016-06-28 11:40   ` [PATCH v2 4/7] doc: typeset '--' " Matthieu Moy
2016-06-28 11:40   ` [PATCH v2 5/7] doc: typeset long options with argument " Matthieu Moy
2016-06-28 11:40   ` [PATCH v2 6/7] CodingGuidelines: formatting HEAD in documentation Matthieu Moy
2016-06-28 11:40   ` [PATCH v2 7/7] doc: typeset HEAD and variants as literal Matthieu Moy
2016-06-30  6:42   ` [PATCH v2 0/7] literal formatting in documentation Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160627185715.GB9594@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=Matthieu.Moy@imag.fr \
    --cc=erwan.mathoniere@ensimag.grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jordan.de-gea@ensimag.grenoble-inp.fr \
    --cc=samuel.groot@ensimag.grenoble-inp.fr \
    --cc=tom.russello@ensimag.grenoble-inp.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).