From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 557392018A for ; Fri, 24 Jun 2016 19:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbcFXTqL (ORCPT ); Fri, 24 Jun 2016 15:46:11 -0400 Received: from cloud.peff.net ([50.56.180.127]:59979 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751089AbcFXTqJ (ORCPT ); Fri, 24 Jun 2016 15:46:09 -0400 Received: (qmail 31514 invoked by uid 102); 24 Jun 2016 19:46:09 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Fri, 24 Jun 2016 15:46:09 -0400 Received: (qmail 22235 invoked by uid 107); 24 Jun 2016 19:46:24 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Fri, 24 Jun 2016 15:46:24 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 24 Jun 2016 15:46:07 -0400 Date: Fri, 24 Jun 2016 15:46:07 -0400 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org, =?utf-8?B?UmVuw6k=?= Scharfe , "Robin H. Johnson" Subject: Re: [PATCH v3 2/4] archive-tar: write extended headers for file sizes >= 8GB Message-ID: <20160624194606.GA6521@sigill.intra.peff.net> References: <20160623231512.GA27683@sigill.intra.peff.net> <20160623232104.GB3668@sigill.intra.peff.net> <20160624191044.GB32118@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jun 24, 2016 at 12:45:05PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > So if anything, I would put a comment here, explaining that ustar cannot > > handle anything larger than this, and POSIX mandates it (but I didn't > > because the commit message already goes into much more detail). > > That sounds like a good thing to do. Not everybody runs "blame" to > find the commit whose log message she must read before touching a > line. Well, they should. My commit messages are works of literature. ;) I'll add a comment. -Peff