Re: [PATCH v2] Refactor recv_sideband()

[Jeff King <peff@peff.net>]

On Fri, Jun 24, 2016 at 07:45:04PM +0200, Johannes Schindelin wrote:

> >   $ git grep -A2 IMPORTANT color.h
> >   color.h: * IMPORTANT: Due to the way these color codes are emulated on Windows,
> >   color.h- * write them only using printf(), fprintf(), and fputs(). In particular,
> >   color.h- * do not use puts() or write().
> > 
> > Your patch converts some fprintf calls to write. What does this mean
> > on Windows for:
> > 
> >   1. Remote servers which send ANSI codes and expect them to look
> >      reasonable (this might be a losing proposition already, as the
> >      server won't know anything about the user's terminal, or whether
> >      output is going to a file).
> > 
> >   2. The use of ANSI_SUFFIX in this function, which uses a similar
> >      escape code.
> 
> Wow, I did not even think that a remote server would send color codes,
> what with the server being unable to query the local terminal via
> isatty().
> 
> Do we *actually* send color via the sideband, like, ever?

We don't, but remember that we forward arbitrary output from hooks.

If the consensus is "nah, it is probably crazy and nobody is doing it
today" then I am fine with that.

I do wonder about the ANSI_SUFFIX thing, though.

-Peff