From: Pranit Bauva <pranit.bauva@gmail.com>
To: git@vger.kernel.org
Cc: Pranit Bauva <pranit.bauva@gmail.com>,
christian.couder@gmail.com, chriscool@tuxfamily.org,
larsxschneider@gmail.com
Subject: [PATCH 1/2] bisect--helper: `is_expected_rev` shell function in C
Date: Wed, 8 Jun 2016 20:54:14 +0530 [thread overview]
Message-ID: <20160608152415.7770-1-pranit.bauva@gmail.com> (raw)
Reimplement `is_expected_rev` shell function in C. This will further be
called from `check_expected_revs` function. This is a quite small
function thus subcommand facility is redundant.
Mentored-by: Lars Schneider <larsxschneider@gmail.com>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
---
This applies on the previous patches.
builtin/bisect--helper.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 4153e8a..06bc9b8 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -160,6 +160,20 @@ int bisect_reset(const char *commit)
return bisect_clean_state();
}
+static int is_expected_rev(const char *expected_hex)
+{
+ struct strbuf actual_hex = STRBUF_INIT;
+
+ if (!file_exists(git_path_bisect_expected_rev()))
+ return 0;
+
+ if (!strbuf_read_file(&actual_hex, git_path_bisect_expected_rev(), 0))
+ return 0;
+
+ strbuf_trim(&actual_hex);
+ return !strcmp(actual_hex.buf, expected_hex);
+}
+
int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
{
enum {
--
2.8.3
next reply other threads:[~2016-06-08 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 15:24 Pranit Bauva [this message]
2016-06-08 15:24 ` [PATCH 2/2] bisect--helper: `check_expected_revs` shell function in C Pranit Bauva
2016-06-09 21:54 ` Eric Sunshine
2016-06-10 7:52 ` Pranit Bauva
2016-06-09 21:33 ` [PATCH 1/2] bisect--helper: `is_expected_rev` " Eric Sunshine
2016-06-09 21:39 ` Eric Sunshine
2016-06-10 13:39 ` Pranit Bauva
2016-06-10 19:14 ` Eric Sunshine
2016-06-11 12:18 ` Pranit Bauva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608152415.7770-1-pranit.bauva@gmail.com \
--to=pranit.bauva@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).