From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: santiago@nyu.edu, git@vger.kernel.org,
Eric Sunshine <sunshine@sunshineco.com>,
Colin Walters <walters@verbum.org>
Subject: Re: [RFC/PATCH] verify-tag: add --check-name flag
Date: Tue, 7 Jun 2016 18:07:44 -0400 [thread overview]
Message-ID: <20160607220743.GA21043@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqy46gods1.fsf@gitster.mtv.corp.google.com>
On Tue, Jun 07, 2016 at 03:05:50PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > On Tue, Jun 07, 2016 at 02:50:23PM -0700, Junio C Hamano wrote:
> >
> >> >> Or it could even do this:
> >> >>
> >> >> tag="$1"
> >> >> if ! git tag -v "$tag"
> >> >> if ! git tag -v "$tag"
> >> >> then
> >> >> echo >&2 "Bad tag."
> >> >> exit 1
> >> >> fi
> >> >> + tag=$(git tag --show-tagname $tag)
> >> >> make dest=/usr/local/$package/$tag install
> >> >
> >> > It is racy. That probably doesn't matter for most callers, but it would
> >> > be nice to be able to get a custom format out of the "-v" invocation.
> >>
> >> Heh, you can do
> >>
> >> - tag="$1"
> >> + tag=$(git rev-parse --verify "$1")
> >>
> >> upfront and it no longer is racy, no?
> >
> > Yes, though that doesn't quite work today. The formatted output comes
> > from "tag -l", which wants a refname.
>
> Puzzled. I didn't even use --format=%(tagname) in the above.
No, but you used --show-tagname, which does not exist today (and which
IMHO should be implemented as --format). Would --show-tagname take
either a tagname _or_ a sha1? I assume it would not be calling
get_sha1(), as having it find refs/heads/$tag would be silly.
-Peff
next prev parent reply other threads:[~2016-06-07 22:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 19:56 [RFC/PATCH] verify-tag: add --check-name flag santiago
2016-06-07 21:05 ` Junio C Hamano
2016-06-07 21:17 ` Jeff King
2016-06-07 21:30 ` Santiago Torres
2016-06-07 21:50 ` Junio C Hamano
2016-06-07 21:55 ` Jeff King
2016-06-07 22:05 ` Junio C Hamano
2016-06-07 22:07 ` Jeff King [this message]
2016-06-07 22:11 ` Junio C Hamano
2016-06-07 22:13 ` Jeff King
2016-06-07 22:16 ` Santiago Torres
2016-06-07 22:21 ` Junio C Hamano
2016-06-07 22:29 ` Jeff King
2016-06-07 22:35 ` Junio C Hamano
2016-06-08 14:21 ` Santiago Torres
2016-06-08 18:43 ` Junio C Hamano
2016-06-09 11:48 ` Michael J Gruber
2016-06-07 21:20 ` Santiago Torres
2016-06-07 21:08 ` Jeff King
2016-06-07 21:13 ` Santiago Torres
2016-06-07 21:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607220743.GA21043@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=santiago@nyu.edu \
--cc=sunshine@sunshineco.com \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).