From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Duclot Subject: Re: [PATCH] userdiff: add built-in pattern for CSS Date: Mon, 6 Jun 2016 09:28:00 +0200 Message-ID: <20160606072800.GA3803@Messiaen> References: <20160524142537.19324-1-william.duclot@ensimag.grenoble-inp.fr> <20160602224809.5167-1-william.duclot@ensimag.grenoble-inp.fr> <57511B2D.7040501@kdbg.org> <20160603094544.GA3865@Messiaen> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Johannes Sixt , git@vger.kernel.org, simon.rabourg@ensimag.grenoble-inp.fr, antoine.queru@ensimag.grenoble-inp.fr, francois.beutin@ensimag.grenoble-inp.fr, Matthieu Moy To: Junio C Hamano X-From: git-owner@vger.kernel.org Mon Jun 06 09:28:15 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b9oxG-0001is-Ml for gcvg-git-2@plane.gmane.org; Mon, 06 Jun 2016 09:28:11 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751782AbcFFH2H (ORCPT ); Mon, 6 Jun 2016 03:28:07 -0400 Received: from zm-etu-ensimag-1.grenet.fr ([130.190.244.117]:37248 "EHLO zm-etu-ensimag-1.grenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbcFFH2F (ORCPT ); Mon, 6 Jun 2016 03:28:05 -0400 Received: from localhost (localhost [127.0.0.1]) by zm-smtpout-1.grenet.fr (Postfix) with ESMTP id 631E82558; Mon, 6 Jun 2016 09:28:02 +0200 (CEST) Received: from zm-smtpout-1.grenet.fr ([127.0.0.1]) by localhost (zm-smtpout-1.grenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r5ruVTceTh-0; Mon, 6 Jun 2016 09:28:02 +0200 (CEST) Received: from zm-smtpauth-2.grenet.fr (zm-smtpauth-2.grenet.fr [130.190.244.123]) by zm-smtpout-1.grenet.fr (Postfix) with ESMTP id 53E05254C; Mon, 6 Jun 2016 09:28:02 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zm-smtpauth-2.grenet.fr (Postfix) with ESMTP id 4D66A2066; Mon, 6 Jun 2016 09:28:02 +0200 (CEST) Received: from zm-smtpauth-2.grenet.fr ([127.0.0.1]) by localhost (zm-smtpauth-2.grenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1qcBHrxpNTP3; Mon, 6 Jun 2016 09:28:02 +0200 (CEST) Received: from Messiaen (eduroam-033140.grenet.fr [130.190.33.140]) by zm-smtpauth-2.grenet.fr (Postfix) with ESMTPSA id 2CAC42055; Mon, 6 Jun 2016 09:28:02 +0200 (CEST) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, Jun 03, 2016 at 08:50:50AM -0700, Junio C Hamano wrote: > William Duclot writes: > > > Here I have to disagree (with you and Junio): the IPATTERN is > > case-insensitive only on the "pattern" regex, not the "word_regex" > > regex. > > Ahh, OK. Obviously both of us overlooked that. Thanks for pushing > back. > > > On the identifier line, I have "A-F" instead of "A-Z" though > > Yeah, that does need updating. Note that I sent a V4 :)