From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t4014: shell portability fix
Date: Wed, 1 Jun 2016 12:07:36 -0400 [thread overview]
Message-ID: <20160601160735.GB9219@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqfusx0wyj.fsf@gitster.mtv.corp.google.com>
On Wed, Jun 01, 2016 at 08:07:16AM -0700, Junio C Hamano wrote:
> > Here's the patch I wrote up earlier (but was too timid to send out after
> > my barrage of emails :) ).
>
> Looks very sensible. I'll drop all these "Attempt to test with
> ksh93 found these breakages" patches and queue this one.
Curious based on our previous discussion, I applied your patches and did
a "make SHELL_PATH=/bin/ksh93 test". There were only a handful of
failures remaining. Some were definitely the "../.git" thing (which
Andreas earlier reported as fixed, though the fix still has not made it
into the version in Debian), but some were just puzzling. I shrugged and
gave up.
> > We sometimes get around this by using env, like:
> >
> > test_must_fail env FOO=BAR some-program
> >
> > But that only works because test_must_fail's arguments are
> > themselves a command which can be run. You can't run:
>
> We can do "test_must_fail test_commit ...", but "test_must_fail env
> FOO=BAR test_commit ..." would not work, right?
>
> If so s/because/when/, perhaps?
Right. What I was trying to say is that it works in this case because
test_must_fail further executes its arguments, which gives us an
opportunity to put the "env" on the right-hand side of the function
call. I'm not sure s/because/when/ makes that any better, though.
Maybe:
We sometimes get around this by using env, like:
test_must_fail env FOO=BAR some-program
But that works for test_must_fail because it further runs its
arguments via the shell, so we can stick the "env" on the right-hand
side of the function. It would not work to do:
env FOO=BAR test_must_fail some-program
because env does not know about our shell functions...
is more clear?
-Peff
next prev parent reply other threads:[~2016-06-01 16:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 22:53 [PATCH] t4014: shell portability fix Junio C Hamano
2016-05-31 22:56 ` Jeff King
2016-06-01 0:09 ` Eric Sunshine
2016-06-01 2:31 ` Jeff King
2016-06-01 3:31 ` Jeff King
2016-06-01 3:44 ` Jeff King
2016-06-01 3:54 ` Jeff King
2016-06-01 5:33 ` Jeff King
2016-06-01 5:40 ` Jeff King
2016-06-01 6:49 ` Junio C Hamano
2016-06-01 6:57 ` Junio C Hamano
2016-06-01 7:04 ` Jeff King
2016-06-01 15:07 ` Junio C Hamano
2016-06-01 16:07 ` Jeff King [this message]
2016-06-01 16:57 ` Junio C Hamano
2016-06-01 16:58 ` Jeff King
2016-06-01 5:48 ` Johannes Sixt
2016-06-01 5:48 ` Jeff King
2016-06-01 6:39 ` Eric Sunshine
2016-06-01 0:09 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601160735.GB9219@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).