From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine Queru Subject: [PATCH v4] upload-pack.c: use of parse-options API Date: Fri, 27 May 2016 16:16:28 +0200 Message-ID: <20160527141628.1677-1-Antoine.Queru@ensimag.grenoble-inp.fr> References: <20160523130231.8725-1-Antoine.Queru@ensimag.grenoble-inp.fr> Cc: william.duclot@ensimag.grenoble-inp.fr, simon.rabourg@ensimag.grenoble-inp.fr, francois.beutin@ensimag.grenoble-inp.fr, Matthieu.Moy@grenoble-inp.fr, gitster@pobox.com, peff@peff.net To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Fri May 27 16:17:19 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b6IZh-0003B0-Hl for gcvg-git-2@plane.gmane.org; Fri, 27 May 2016 16:17:17 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752172AbcE0ORO (ORCPT ); Fri, 27 May 2016 10:17:14 -0400 Received: from zm-etu-ensimag-1.grenet.fr ([130.190.244.117]:56653 "EHLO zm-etu-ensimag-1.grenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbcE0ORN (ORCPT ); Fri, 27 May 2016 10:17:13 -0400 Received: from localhost (localhost [127.0.0.1]) by zm-smtpout-1.grenet.fr (Postfix) with ESMTP id CD1762570; Fri, 27 May 2016 16:17:04 +0200 (CEST) Received: from zm-smtpout-1.grenet.fr ([127.0.0.1]) by localhost (zm-smtpout-1.grenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FKi4EXI-mkwm; Fri, 27 May 2016 16:17:04 +0200 (CEST) Received: from zm-smtpauth-2.grenet.fr (zm-smtpauth-2.grenet.fr [130.190.244.123]) by zm-smtpout-1.grenet.fr (Postfix) with ESMTP id BCA7B256E; Fri, 27 May 2016 16:17:04 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zm-smtpauth-2.grenet.fr (Postfix) with ESMTP id B6BFC2077; Fri, 27 May 2016 16:17:04 +0200 (CEST) Received: from zm-smtpauth-2.grenet.fr ([127.0.0.1]) by localhost (zm-smtpauth-2.grenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G56MQHIqf8Dy; Fri, 27 May 2016 16:17:04 +0200 (CEST) Received: from quetutemobile.grenet.fr (eduroam-033140.grenet.fr [130.190.33.140]) by zm-smtpauth-2.grenet.fr (Postfix) with ESMTPSA id 9C1AA2055; Fri, 27 May 2016 16:17:04 +0200 (CEST) X-Mailer: git-send-email 2.8.2.403.g31e708f In-Reply-To: <20160523130231.8725-1-Antoine.Queru@ensimag.grenoble-inp.fr> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Option parsing now uses the parser API instead of a local parser. Code is now more compact. Description for --stateless-rpc and --advertise-refs come from the commit 42526b4 (Add stateless RPC options to upload-pack, receive-pack, 2009-10-30). Signed-off-by: Antoine Queru Signed-off-by: Matthieu Moy --- Change since v3 : Commit message is now well formated. Updated documentation. Documentation/git-upload-pack.txt | 17 +++++++++-- upload-pack.c | 59 +++++++++++++++++---------------------- 2 files changed, 40 insertions(+), 36 deletions(-) diff --git a/Documentation/git-upload-pack.txt b/Documentation/git-upload-pack.txt index 0abc806..22ddf8a 100644 --- a/Documentation/git-upload-pack.txt +++ b/Documentation/git-upload-pack.txt @@ -9,8 +9,8 @@ git-upload-pack - Send objects packed back to git-fetch-pack SYNOPSIS -------- [verse] -'git-upload-pack' [--strict] [--timeout=] - +'git-upload-pack' [--strict] [--timeout=] [--stateless-rpc] + [--advertise-refs] DESCRIPTION ----------- Invoked by 'git fetch-pack', learns what @@ -31,6 +31,19 @@ OPTIONS --timeout=:: Interrupt transfer after seconds of inactivity. +--stateless-rpc:: + the programs now assume they may perform only a single read-write + cycle with stdin and stdout. This fits with the HTTP POST request + processing model where a program may read the request, write a + response, and must exit. + +--advertise-refs:: + When --advertise-refs is passed as a command line parameter only + the initial ref advertisement is output, and the program exits + immediately. This fits with the HTTP GET request model, where + no request content is received but a response must be produced. + + :: The repository to sync from. diff --git a/upload-pack.c b/upload-pack.c index dc802a0..2d53c7b 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -14,8 +14,12 @@ #include "sigchain.h" #include "version.h" #include "string-list.h" +#include "parse-options.h" -static const char upload_pack_usage[] = "git upload-pack [--strict] [--timeout=] "; +static const char * const upload_pack_usage[] = { + N_("git upload-pack [options] "), + NULL +}; /* Remember to update object flag allocation in object.h */ #define THEY_HAVE (1u << 11) @@ -817,11 +821,21 @@ static int upload_pack_config(const char *var, const char *value, void *unused) return parse_hide_refs_config(var, value, "uploadpack"); } -int main(int argc, char **argv) +int main(int argc, const char **argv) { - char *dir; - int i; + const char *dir; int strict = 0; + struct option options[] = { + OPT_BOOL(0, "stateless-rpc", &stateless_rpc, + N_("quit after a single request/response exchange")), + OPT_BOOL(0, "advertise-refs", &advertise_refs, + N_("only the initial ref advertisement is output, program exits immediately")), + OPT_BOOL(0, "strict", &strict, + N_("do not try /.git/ if is no Git directory")), + OPT_INTEGER(0, "timeout", &timeout, + N_("interrupt transfer after seconds of inactivity")), + OPT_END() + }; git_setup_gettext(); @@ -829,40 +843,17 @@ int main(int argc, char **argv) git_extract_argv0_path(argv[0]); check_replace_refs = 0; - for (i = 1; i < argc; i++) { - char *arg = argv[i]; - - if (arg[0] != '-') - break; - if (!strcmp(arg, "--advertise-refs")) { - advertise_refs = 1; - continue; - } - if (!strcmp(arg, "--stateless-rpc")) { - stateless_rpc = 1; - continue; - } - if (!strcmp(arg, "--strict")) { - strict = 1; - continue; - } - if (starts_with(arg, "--timeout=")) { - timeout = atoi(arg+10); - daemon_mode = 1; - continue; - } - if (!strcmp(arg, "--")) { - i++; - break; - } - } + argc = parse_options(argc, argv, NULL, options, upload_pack_usage, 0); + + if (argc != 1) + usage_with_options(upload_pack_usage, options); - if (i != argc-1) - usage(upload_pack_usage); + if (timeout) + daemon_mode = 1; setup_path(); - dir = argv[i]; + dir = argv[0]; if (!enter_repo(dir, strict)) die("'%s' does not appear to be a git repository", dir); -- 2.8.2.403.g31e708f