From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: sunshine@sunshineco.com, gitster@pobox.com, pclouds@gmail.com,
ramsay@ramsayjones.plus.com, Stefan Beller <sbeller@google.com>
Subject: [PATCHv3 0/2] Persistent submodule pathspec specification
Date: Thu, 26 May 2016 13:47:28 -0700 [thread overview]
Message-ID: <20160526204730.20309-1-sbeller@google.com> (raw)
Changes since v2:
* I replaced one 0 by NULL as pointed out by Ramsay, and reformatted the line
to stay within 80 characters:
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -908,8 +908,10 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
struct string_list_item *item;
struct strbuf sb = STRBUF_INIT;
for_each_string_list_item(item, &init_submodules) {
- strbuf_addf(&sb, "submodule.defaultUpdatePath=%s", item->string);
- string_list_append(&option_config, strbuf_detach(&sb, 0));
+ strbuf_addf(&sb, "submodule.defaultUpdatePath=%s",
+ item->string);
+ string_list_append(&option_config,
+ strbuf_detach(&sb, NULL));
}
}
Changes since v1:
* fixed a broken && chain in a subshell for testing, as pointed out by Eric!
This was part of the former series 'submodule groups'.
However the labeling was ripped out and goes in its own series
sb/pathspec-label.
First we introduce a switch `--init-default-path` for `git submodule update`
which will read the pathspec to initialize the submodules not from the command
line but from `submodule.defaultUpdatePath`, which can be configured permanently.
The second patch utilizes this by having `clone` set that config option
and using that new option when calling to update the submodules.
Thanks,
Stefan
Stefan Beller (2):
submodule update: add `--init-default-path` switch
clone: add --init-submodule=<pathspec> switch
Documentation/config.txt | 5 ++
Documentation/git-clone.txt | 25 +++++---
Documentation/git-submodule.txt | 11 +++-
builtin/clone.c | 36 ++++++++++-
git-submodule.sh | 21 ++++++-
t/t7400-submodule-basic.sh | 134 ++++++++++++++++++++++++++++++++++++++++
6 files changed, 218 insertions(+), 14 deletions(-)
--
2.9.0.rc0.2.g145fc64
base-commit: 3a0f269e7c82aa3a87323cb7ae04ac5f129f036b
next reply other threads:[~2016-05-26 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 20:47 Stefan Beller [this message]
2016-05-26 20:47 ` [PATCH 1/2] submodule update: add `--init-default-path` switch Stefan Beller
2016-05-26 20:47 ` [PATCH 2/2] clone: add --init-submodule=<pathspec> switch Stefan Beller
2016-05-26 21:12 ` [PATCHv3 0/2] Persistent submodule pathspec specification Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526204730.20309-1-sbeller@google.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).