From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] daemon: enable SO_KEEPALIVE for all sockets
Date: Wed, 25 May 2016 23:11:14 +0000 [thread overview]
Message-ID: <20160525231114.GA20691@dcvr.yhbt.net> (raw)
In-Reply-To: <xmqq37p5zrjk.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> This makes sense as a follow-up to e47a8583 (enable SO_KEEPALIVE for
> connected TCP sockets, 2011-12-06), I think.
Yes, a15d069a19867 for http, too; hat trick :>
Anyways, it might've helped Savannah when they had networking
problems:
http://mid.gmane.org/20160524214102858920068@bob.proulx.com
They might be running an old version that didn't send keepalive
heartbeats during packing, too. But SO_KEEPALIVE will still
help during init when --init-timeout is not set.
Perhaps it also makes sense to squash the following xinetd
setting into giteveryday.txt, too; since some users could be
running out-of-date git but reading new documentation on
the web:
--- a/Documentation/giteveryday.txt
+++ b/Documentation/giteveryday.txt
@@ -390,6 +390,7 @@ service git
server = /usr/bin/git-daemon
server_args = --inetd --export-all --base-path=/pub/scm
log_on_failure += USERID
+ flags = KEEPALIVE
}
------------
+
prev parent reply other threads:[~2016-05-25 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 3:15 [PATCH] daemon: enable SO_KEEPALIVE for all sockets Eric Wong
2016-05-25 22:42 ` Jeff King
2016-05-25 22:44 ` Junio C Hamano
2016-05-25 23:11 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525231114.GA20691@dcvr.yhbt.net \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).