From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Subject: Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port
Date: Tue, 24 May 2016 06:50:16 +0900 [thread overview]
Message-ID: <20160523215016.GA20618@glandium.org> (raw)
In-Reply-To: <xmqqwpmk797y.fsf@gitster.mtv.corp.google.com>
On Mon, May 23, 2016 at 02:30:57PM -0700, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
> >>>> get_host_and_port(&ssh_host, &port);
> >>>> + /* get_host_and_port may not return a port
> >>>> even when
> >>>> + * there is one: In the [host:port]:path case,
> >>>> + * get_host_and_port is called with "[host:port]" and
> >>>> + * returns "host:port" and NULL.
> >>>> + * In that specific case, we still need to split the
> >>>> + * port. */
> >>> Is it worth to mention that this case is "still supported legacy" ?
> >> If it's worth mentioning anywhere, it seems to me it would start with
> >> urls.txt?
> >>
> >> Mike
> >>
> > I don't know.
> > urls.txt is for Git users, and connect.c is for Git developers.
> > urls.txt does not mention that Git follows any RFC when parsing the
> > URLS', it doesn't claim to be 100% compliant.
> > Even if it makes sense to do so, as many user simply expect Git to accept
> > RFC compliant URL's, and it makes the development easier, if there is
> > an already
> > written specification, that describes all the details.
> > The parser is not 100% RFC compliant, one example:
> > - old-style usgage like "git clone [host:222]:~/path/to/repo are supported
"This parser handles the urls described in urls.txt" is about as much as
there is to say IMHO.
> Is it an option to fix get_host_and_port() so that it returns what
> the caller expects even when it is given "[host:port]"? When the
> caller passes other forms like "host:port", it expects to get "host"
> and "port" parsed out into two variables. Why can't the caller
> expect to see the same happen when feeding "[host:port]" to the
> function?
After this series, there's only one use of get_host_and_port(). As well
as one use of host_end() and get_port(). They become implementation
details of the parse_connect_url function. And as I mentioned in the
cover letter this round, parse_connect_url could be further modified to
avoid the kind of back-and-forth that's going on between these
functions. But I'd rather leave that for later.
Mike
next prev parent reply other threads:[~2016-05-23 21:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 23:17 [PATCH v7 0/9] connect: various cleanups Mike Hommey
2016-05-21 23:17 ` [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port Mike Hommey
2016-05-22 2:40 ` Eric Sunshine
2016-05-22 6:07 ` Torsten Bögershausen
2016-05-22 8:03 ` Mike Hommey
2016-05-23 4:31 ` Torsten Bögershausen
2016-05-23 21:30 ` Junio C Hamano
2016-05-23 21:50 ` Mike Hommey [this message]
2016-05-24 4:44 ` Torsten Bögershausen
2016-05-25 23:34 ` Mike Hommey
2016-05-26 5:35 ` Torsten Bögershausen
2016-05-21 23:17 ` [PATCH v7 2/9] connect: call get_host_and_port() earlier Mike Hommey
2016-05-21 23:17 ` [PATCH v7 3/9] connect: re-derive a host:port string from the separate host and port variables Mike Hommey
2016-05-21 23:17 ` [PATCH v7 4/9] connect: make parse_connect_url() return separated host and port Mike Hommey
2016-05-21 23:17 ` [PATCH v7 5/9] connect: group CONNECT_DIAG_URL handling code Mike Hommey
2016-05-21 23:17 ` [PATCH v7 6/9] connect: make parse_connect_url() return the user part of the url as a separate value Mike Hommey
2016-05-21 23:17 ` [PATCH v7 7/9] connect: change the --diag-url output to separate user and host Mike Hommey
2016-05-21 23:17 ` [PATCH v7 8/9] connect: actively reject git:// urls with a user part Mike Hommey
2016-05-21 23:17 ` [PATCH v7 9/9] connect: move ssh command line preparation to a separate function Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523215016.GA20618@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).