From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Wong <e@80x24.org>
Subject: Re: [RFC-PATCH 1/2] send-email: new option to quote an email and
 reply to
Date: Mon, 23 May 2016 19:55:04 +0000
Message-ID: <20160523195504.GA8957@dcvr.yhbt.net>
References: <1464031829-6107-1-git-send-email-tom.russello@grenoble-inp.org>
 <1464031829-6107-2-git-send-email-tom.russello@grenoble-inp.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org, samuel.groot@grenoble-inp.org,
	matthieu.moy@grenoble-inp.fr, erwan.mathoniere@grenoble-inp.org,
	jordan.de-gea@ensimag.grenoble-inp.fr,
	Tom Russello <tom.russello@ensimag.grenoble-inp.fr>
To: Tom Russello <tom.russello@grenoble-inp.org>
X-From: git-owner@vger.kernel.org Mon May 23 21:54:49 2016
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1b4vw8-0004UT-JX
	for gcvg-git-2@plane.gmane.org; Mon, 23 May 2016 21:54:48 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754583AbcEWTyo (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Mon, 23 May 2016 15:54:44 -0400
Received: from dcvr.yhbt.net ([64.71.152.64]:33898 "EHLO dcvr.yhbt.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752892AbcEWTyn (ORCPT <rfc822;git@vger.kernel.org>);
	Mon, 23 May 2016 15:54:43 -0400
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 834F11FCC7;
	Mon, 23 May 2016 19:54:42 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1464031829-6107-2-git-send-email-tom.russello@grenoble-inp.org>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/295384>

Tom Russello <tom.russello@grenoble-inp.org> wrote:
> This new option takes an email message file, parses it, fills the "To",
> "Subject" and "Cc" fields appropriately and quote the message.
> This option involves the `--compose` mode to edit the cover letter quoting the
> given email.

Cool!  There should probably be some help text to encourage
trimming down the quoted text to only relevant portions.

> +	#Message body
> +	while (<$fh>) {
> +		#for files containing crlf line endings
> +		$_=~ s/\r//g;
> +		my $space="";
> +		if (/^[^>]/) {
> +			$space = " ";
> +		}
> +		$message_quoted .=  ">".$space.$_;

Is this really necessary to switch between "> " and ">" prefix?
AFAIK, MUAs prefix unconditionally with "> ".
At least that's how mutt does it...