From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, tboegi@web.de
Subject: Re: [PATCH v6 2/9] connect: only match the host with core.gitProxy
Date: Sat, 21 May 2016 07:30:54 +0900 [thread overview]
Message-ID: <20160520223054.GB7752@glandium.org> (raw)
In-Reply-To: <xmqqbn40cser.fsf@gitster.mtv.corp.google.com>
On Fri, May 20, 2016 at 02:48:28PM -0700, Junio C Hamano wrote:
> So, even if we agree that per-port behaviour is not something we
> would use if we were building the system without any existing users
> today, I do not think we want "git now fails with an error" at all.
> It goes against the approach Git takes to give smooth transtion to
> users when we must break backward compatibility.
I don't disagree. I went with a hard fail because it was easier. I'm
not too keen blocking this series on this transition happening. So I'll
try to finish this series without this change, and we can separate this
transition discussion from the rest of the connect.c changes.
Mike
next prev parent reply other threads:[~2016-05-20 22:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 1:35 [PATCH v6 0/9] connect: various cleanups Mike Hommey
2016-05-17 1:35 ` [PATCH v6 1/9] connect: call get_host_and_port() earlier Mike Hommey
2016-05-20 20:58 ` Junio C Hamano
2016-05-20 22:14 ` Mike Hommey
2016-05-20 22:20 ` Junio C Hamano
2016-05-20 22:28 ` Mike Hommey
2016-05-17 1:35 ` [PATCH v6 2/9] connect: only match the host with core.gitProxy Mike Hommey
2016-05-20 21:48 ` Junio C Hamano
2016-05-20 22:30 ` Mike Hommey [this message]
2016-05-20 22:56 ` Junio C Hamano
2016-05-17 1:35 ` [PATCH v6 3/9] connect: fill the host header in the git protocol with the host and port variables Mike Hommey
2016-05-17 1:35 ` [PATCH v6 4/9] connect: make parse_connect_url() return separated host and port Mike Hommey
2016-05-17 1:35 ` [PATCH v6 5/9] connect: group CONNECT_DIAG_URL handling code Mike Hommey
2016-05-17 1:35 ` [PATCH v6 6/9] connect: make parse_connect_url() return the user part of the url as a separate value Mike Hommey
2016-05-17 1:35 ` [PATCH v6 7/9] connect: change the --diag-url output to separate user and host Mike Hommey
2016-05-17 1:35 ` [PATCH v6 8/9] connect: actively reject git:// urls with a user part Mike Hommey
2016-05-17 1:35 ` [PATCH v6 9/9] connect: move ssh command line preparation to a separate function Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520223054.GB7752@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).