From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff King <peff@peff.net>
Subject: Re: [PATCH v4 1/2] Documentation: fix linkgit references
Date: Wed, 4 May 2016 19:53:32 -0400
Message-ID: <20160504235332.GA13102@sigill.intra.peff.net>
References: <xmqq8tzpfrt0.fsf@gitster.mtv.corp.google.com>
 <20160504213149.GA22828@sigill.intra.peff.net>
 <xmqq4madfqxs.fsf@gitster.mtv.corp.google.com>
 <20160504214412.GA25237@sigill.intra.peff.net>
 <xmqqk2j9ebj8.fsf@gitster.mtv.corp.google.com>
 <20160504220935.GA26339@sigill.intra.peff.net>
 <xmqq60uteacx.fsf@gitster.mtv.corp.google.com>
 <xmqq1t5he9we.fsf@gitster.mtv.corp.google.com>
 <xmqqfutxcsio.fsf@gitster.mtv.corp.google.com>
 <20160504234153.GA12837@sigill.intra.peff.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: Lars Schneider <larsxschneider@gmail.com>,
	Ramsay Jones <ramsay@ramsayjones.plus.com>,
	git@vger.kernel.org, Matthieu.Moy@grenoble-inp.fr,
	sbeller@google.com
To: Junio C Hamano <gitster@pobox.com>
X-From: git-owner@vger.kernel.org Thu May 05 01:53:39 2016
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1ay6br-00064E-11
	for gcvg-git-2@plane.gmane.org; Thu, 05 May 2016 01:53:39 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754542AbcEDXxf (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Wed, 4 May 2016 19:53:35 -0400
Received: from cloud.peff.net ([50.56.180.127]:34393 "HELO cloud.peff.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP
	id S1753952AbcEDXxf (ORCPT <rfc822;git@vger.kernel.org>);
	Wed, 4 May 2016 19:53:35 -0400
Received: (qmail 12900 invoked by uid 102); 4 May 2016 23:53:34 -0000
Received: from Unknown (HELO peff.net) (10.0.1.2)
    by cloud.peff.net (qpsmtpd/0.84) with SMTP; Wed, 04 May 2016 19:53:34 -0400
Received: (qmail 15660 invoked by uid 107); 4 May 2016 23:53:46 -0000
Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7)
    by peff.net (qpsmtpd/0.84) with SMTP; Wed, 04 May 2016 19:53:46 -0400
Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 04 May 2016 19:53:32 -0400
Content-Disposition: inline
In-Reply-To: <20160504234153.GA12837@sigill.intra.peff.net>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/293628>

On Wed, May 04, 2016 at 07:41:53PM -0400, Jeff King wrote:

> On Wed, May 04, 2016 at 04:28:31PM -0700, Junio C Hamano wrote:
> 
> > Junio C Hamano <gitster@pobox.com> writes:
> > 
> > > Gaah, the Makefile part of the final patch is wrong; we do not check
> > > the included sources at all if we only passed the top-level targets'
> > > sources.
> > 
> > I ended up queuing an enhanced version of File::Find based one on
> > 'pu', but I won't be posting it here today.
> 
> Hmm. It seems like we should still be able to drive it from the Makefile
> using the dependencies generated by build-docdep.

Having just read that script, it is blindly looking at "*.txt", so...as
long as that is what your script is doing (and it looks like the version
in pu is), I don't think there's any reason to get more complicated. The
only difference is that build-docdep does not even bother looking in
subdirectories (maybe it should, since we now build stuff in technical,
I think).

-Peff